Attachment 118181 Details for Bug 27926 – Bug 27926: (QA follow-up) Switch to using data-order

[patch] Bug 27926: (QA follow-up) Switch to using data-order

Bug-27926-QA-follow-up-Switch-to-using-data-order.patch (text/plain), 2.07 KB, created by Martin Renvoize (ashimema) on 2021-03-12 08:51:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-12 08:51:07 UTC

Size: 2.07 KB

patch

obsolete

>From eab1b74f310003e3311a1c1ea799ae2a71116131 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 12 Mar 2021 08:48:59 +0000
>Subject: [PATCH] Bug 27926: (QA follow-up) Switch to using data-order
>
>This patch switches away from using the title attribute for ordering and
>instead uses data-order which is supported in modern DataTables.  This
>has the effect of allowing our ordering to continue to work but without
>adding the unwanted tooltip on hover.
>
>Test plan
>1/ Ensure sorting is still working as expected
>2/ Hover over any of the date of birth fields and note that you are not
>longer faced with a tooltip.
>3/ Signoff
>---
> .../prog/en/includes/circ-patron-search-results.inc           | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
>index 1a67d38381..3864011c40 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-patron-search-results.inc
>@@ -4,7 +4,7 @@
>         <tr>
>             <th>Name</th>
>             <th>Card number</th>
>-            <th class="title-string">Date of birth</th>
>+            <th>Date of birth</th>
>             <th>Category</th>
>             <th>Library</th>
>             <th>Address</th>
>@@ -26,7 +26,7 @@
>                     <td><a href="[% data_url | url %]">[% borrower.surname | html %], [% borrower.firstname | html %]</a></td>
>             [% END %]
>                 <td>[% borrower.cardnumber | html %]</td>
>-                <td><span title="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</span></td>
>+                <td data-order="[% borrower.dateofbirth | html %]">[% INCLUDE 'patron-age.inc' patron = borrower %]</td>
>                 <td>[% Categories.GetName( borrower.categorycode ) | html %]</td>
>                 <td>[% Branches.GetName( borrower.branchcode ) | html %]</td>
>                 <td>[% borrower.address | html %]</td>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27926: 118118 | 118124 | 118181 | 119159 | 119160