Bugzilla – Attachment 11820 Details for
Bug 5911
Transport Cost Matrix of transporting an item between branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
bug_5911 follow-up: removed debug() calls and ;;
bug5911-follow-up-removed-debug-calls-and-.patch (text/plain), 2.44 KB, created by
Srdjan Jankovic
on 2012-08-24 00:51:53 UTC
(
hide
)
Description:
bug_5911 follow-up: removed debug() calls and ;;
Filename:
MIME Type:
Creator:
Srdjan Jankovic
Created:
2012-08-24 00:51:53 UTC
Size:
2.44 KB
patch
obsolete
>From 922508f8f3bbd02f6ee22b0f3c26d8da3c6e15d5 Mon Sep 17 00:00:00 2001 >From: Srdjan <srdjan@catalyst.net.nz> >Date: Fri, 24 Aug 2012 12:48:31 +1200 >Subject: [PATCH] bug_5911 follow-up: removed debug() calls and ;; > >--- > C4/HoldsQueue.pm | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index d7696dd..1e40766 100755 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -167,7 +167,6 @@ sub CreateQueue { > my $transport_cost_matrix; > my $use_transport_cost_matrix = C4::Context->preference("UseTransportCostMatrix"); > if ($use_transport_cost_matrix) { >- debug( "Using cost matrix" ); > $transport_cost_matrix = TransportCostMatrix(); > unless (keys %$transport_cost_matrix) { > warn "UseTransportCostMatrix set to yes, but matrix not populated"; >@@ -175,12 +174,10 @@ sub CreateQueue { > } > } > unless ($transport_cost_matrix) { >- debug( "Not using cost matrix" ); > $branches_to_use = load_branches_to_pull_from(); > } > > my $bibs_with_pending_requests = GetBibsWithPendingHoldRequests(); >- debug( "bibs_with_pending_requests: ".Dumper($bibs_with_pending_requests) ); > > foreach my $biblionumber (@$bibs_with_pending_requests) { > $total_bibs++; >@@ -192,7 +189,7 @@ sub CreateQueue { > my $item_map = MapItemsToHoldRequests($hold_requests, $available_items, $branches_to_use, $transport_cost_matrix); > $item_map or next; > my $item_map_size = scalar(keys %$item_map) >- or next;; >+ or next; > > $num_items_mapped += $item_map_size; > CreatePicklistFromItemMap($item_map); >@@ -351,7 +348,6 @@ sub MapItemsToHoldRequests { > return unless scalar(@$hold_requests) > 0; > return unless scalar(@$available_items) > 0; > >- debug( "MapItemsToHoldRequests() for ", Dumper($hold_requests, $available_items, $branches_to_use, $transport_cost_matrix) ); > my $automatic_return = C4::Context->preference("AutomaticItemReturn"); > > # identify item-level requests >@@ -500,7 +496,6 @@ sub MapItemsToHoldRequests { > > sub CreatePicklistFromItemMap { > my $item_map = shift; >- debug ("CreatePicklistFromItemMap for ", Dumper($item_map) ); > > my $dbh = C4::Context->dbh; > >@@ -564,10 +559,6 @@ sub AddToHoldTargetMap { > > # Helper functions, not part of any interface > >-sub debug { >-# warn @_; >-} >- > sub _trim { > return $_[0] unless $_[0]; > $_[0] =~ s/^\s+//; >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5911
:
3559
|
4689
|
7799
|
9576
|
9600
|
9626
|
9752
|
9850
|
10241
|
10431
|
10733
|
10882
|
10919
|
11075
|
11095
|
11096
|
11140
|
11144
|
11777
|
11820
|
11971