Attachment 118200 Details for Bug 26734 – Bug 26734: (QA follow-up) Add 'tendered' and 'change' to notice

[patch] Bug 26734: (QA follow-up) Add 'tendered' and 'change' to notice

Bug-26734-QA-follow-up-Add-tendered-and-change-to-.patch (text/plain), 2.23 KB, created by Martin Renvoize (ashimema) on 2021-03-12 14:23:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-12 14:23:13 UTC

Size: 2.23 KB

patch

obsolete

>From d0a5e79430d0a6f068f78fad5f6d8cb4418810e9 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 12 Mar 2021 14:21:41 +0000
>Subject: [PATCH] Bug 26734: (QA follow-up) Add 'tendered' and 'change' to
> notice
>
>We include 'tendered' and 'change' parameters in the call to
>GetPreparedLetter for the fee receipt slip.. we may as well include them
>in the sample notice ;)
>---
> installer/data/mysql/atomicupdate/bug_26734.perl     | 11 +++++++++++
> installer/data/mysql/en/mandatory/sample_notices.yml | 11 +++++++++++
> 2 files changed, 22 insertions(+)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_26734.perl b/installer/data/mysql/atomicupdate/bug_26734.perl
>index faabb6b91b..048f9368fe 100644
>--- a/installer/data/mysql/atomicupdate/bug_26734.perl
>+++ b/installer/data/mysql/atomicupdate/bug_26734.perl
>@@ -136,6 +136,17 @@ if ( CheckVersion($DBversion) ) {
>     <td class="debit">[% debit.amountoutstanding | $Price %]</td>
>   </tr>
> 
>+  [% IF ( tendered ) %]
>+    <tr>
>+      <td colspan="3">Amount tendered: </td>
>+      <td>[% tendered | $Price %]</td>
>+    </tr>
>+    <tr>
>+      <td colspan="3">Change given: </td>
>+      <td>[% change | $Price %]</td>
>+    </tr>
>+  [% END %]
>+
>   <tfoot>
>     <tr>
>       <td colspan="4">Total outstanding dues as on date: </td>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 1f85e0b56e..f8b4b09778 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -95,6 +95,17 @@ tables:
>             - "    <td class=\"credit\">[% credit.amount | $Price %]</td>"
>             - " </tr>"
>             - ""
>+            - "[% IF ( tendered ) %]"
>+            - "  <tr>"
>+            - "    <td colspan=\"3\">Amount tendered: </td>"
>+            - "    <td>[% tendered | $Price %]</td>"
>+            - "  </tr>"
>+            - "  <tr>"
>+            - "    <td colspan=\"3\">Change given: </td>"
>+            - "    <td>[% change | $Price %]</td>"
>+            - "  </tr>"
>+            - "[% END %]"
>+            - ""
>             - "<tfoot>"
>             - "  <tr>"
>             - "    <td colspan=\"3\">Total outstanding dues as on date: </td>"
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26734: 111976 | 111977 | 111978 | 112023 | 112024 | 112025 | 112026 | 116257 | 116259 | 116260 | 116261 | 116262 | 116263 | 116272 | 116275 | 116276 | 116277 | 116278 | 116279 | 116644 | 116645 | 116646 | 116647 | 116648 | 116655 | 116656 | 116657 | 116658 | 116659 | 116663 | 116664 | 116665 | 116666 | 116667 | 117261 | 117262 | 117263 | 117264 | 117265 | 118191 | 118192 | 118193 | 118194 | 118195 | 118196 | 118197 | 118200 | 118482 | 118483 | 118484 | 118485 | 118486 | 118487 | 118488 | 118489 | 119350 | 119351 | 119352 | 119353 | 119354 | 119355 | 119356 | 119357 | 119358 | 119642 | 120077 | 121446 | 121449