Bugzilla – Attachment 118206 Details for
Bug 27934
Table sorting using title-string option is obsolete
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27934: Update waiting_holds.inc to use data-order
Bug-27934-Update-waitingholdsinc-to-use-data-order.patch (text/plain), 2.32 KB, created by
ByWater Sandboxes
on 2021-03-12 15:12:20 UTC
(
hide
)
Description:
Bug 27934: Update waiting_holds.inc to use data-order
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2021-03-12 15:12:20 UTC
Size:
2.32 KB
patch
obsolete
>From 3d59b011419e6e973faddccbbda5957da7218e45 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 12 Mar 2021 08:56:55 +0000 >Subject: [PATCH] Bug 27934: Update waiting_holds.inc to use data-order > >This patch updates the waiting_holds table to use data-order attributes >on the "Waiting since" and "Date hold placed" fields. > >Test plan >1/ Prior to applying the patch navigate to a page that displays waiting holds >2/ Hover over the the "Waiting since" and "Date hold placed" data fields >and note that you are faced with a tooltip with the iso formatted date. >3/ Apply the patch >4/ Check that sorting still works as expected for the two columns >5/ You should no longer be able to trigger the tooltip > >Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index bf47e822aa..39249ea6c7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -3,8 +3,8 @@ > <table id="[% table_name | html %]"> > <thead> > <tr> >- <th class="title-string">Waiting since</th> >- <th class="title-string">Date hold placed</th> >+ <th>Waiting since</th> >+ <th>Date hold placed</th> > <th class="anti-the">Title</th> > <th>Patron</th> > <th>Home library</th> >@@ -19,8 +19,8 @@ > <tbody> > [% FOREACH reserveloo IN reserveloop %] > <tr> >- <td><span title="[% reserveloo.waitingdate | html %]">[% reserveloo.waitingdate | $KohaDates %]</span></td> >- <td><span title="[% reserveloo.reservedate | html %]">[% reserveloo.reservedate | $KohaDates %]</span></td> >+ <td data-order="[% reserveloo.waitingdate | html %]">[% reserveloo.waitingdate | $KohaDates %]</td> >+ <td data-order="[% reserveloo.reservedate | html %]">[% reserveloo.reservedate | $KohaDates %]</td> > <td> > [% INCLUDE 'biblio-title.inc' biblio=reserveloo.biblio link = 1 %] > [% UNLESS ( item_level_itypes ) %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27934
:
118182
| 118206