Attachment 118212 Details for Bug 26689 – Bug 26689: Check for specific template then fallback - printinvoice

[patch] Bug 26689: Check for specific template then fallback - printinvoice

Bug-26689-Check-for-specific-template-then-fallbac.patch (text/plain), 1.83 KB, created by Martin Renvoize (ashimema) on 2021-03-12 16:18:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-12 16:18:52 UTC

Size: 1.83 KB

patch

obsolete

>From a972eb7590fc0f14b66b73de70e962c433da6935 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 12 Mar 2021 16:09:22 +0000
>Subject: [PATCH] Bug 26689: Check for specific template then fallback -
> printinvoice
>
>This patch adds a check for a more specific ACCOUNT_DEBIT template
>(named to match the debit_type_code of the credit line) prior to
>falling back to the ACCOUNT_DEBIT template.
>
>Test plan
>1/ On a patrons account page use the print option on a series of debit
>lines with differing credit types (Overdue, Payout)
>2/ Note that the same template 'ACCOUNT_DEBIT' is used for all types
>3/ Apply the patch
>4/ Run step 1 again and note all still print using ACCOUNT_DEBIT
>5/ Add a new notice template under the 'circulation' module with a code
>that matches one of your account debit types (OVERDUE, PAYOUT)
>6/ Run step 1 again and note that where you have added a specific notice
>for that debit type it has been used.
>---
> members/printinvoice.pl | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/members/printinvoice.pl b/members/printinvoice.pl
>index 97b7f58f17..192c63f26a 100755
>--- a/members/printinvoice.pl
>+++ b/members/printinvoice.pl
>@@ -56,6 +56,18 @@ output_and_exit_if_error(
> );
> 
> my $letter = C4::Letters::GetPreparedLetter(
>+    module                 => 'circulation',
>+    letter_code            => $debit->debit_type_code,
>+    branchcode             => C4::Context::mybranch,
>+    message_transport_type => 'print',
>+    lang                   => $patron->lang,
>+    tables                 => {
>+        debits    => $debit_id,
>+        borrowers => $patron->borrowernumber
>+    }
>+);
>+
>+$letter //= C4::Letters::GetPreparedLetter(
>     module                 => 'circulation',
>     letter_code            => 'ACCOUNT_DEBIT',
>     branchcode             => C4::Context::mybranch,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26689: 112081 | 118204 | 118211 | 118212 | 119572 | 119573 | 119574 | 119575 | 135113 | 135114 | 135685 | 135686 | 136744