Attachment 118228 Details for Bug 26999 – Bug 26999: Make 'Any library' translatable when placing a hold

[patch] Bug 26999: Make 'Any library' translatable when placing a hold

Bug-26999-Make-Any-library-translatable-when-placi.patch (text/plain), 2.72 KB, created by Tomás Cohen Arazi (tcohen) on 2021-03-15 11:40:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-03-15 11:40:37 UTC

Size: 2.72 KB

patch

obsolete

>From 0655b91f0f2209e71588238e2a3ef8fc0563fd8d Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 15 Mar 2021 08:05:02 -0300
>Subject: [PATCH] Bug 26999: Make 'Any library' translatable when placing a
> hold
>
>This patch makes the 'Any library' string translatable, by converting it
>into a flag and using it accordingly on the request.tt template.
>
>To test:
>1. Have the 'Hold pickup library match' set to 'any library' on the
>   circultation rules.
>2. Open the page to place a hold on a biblio with some items
>=> SUCCESS: The item says 'Any library' on the 'Allowed pickup
>locations' column.
>3. Apply this patch
>4. Repeat 2
>=> SUCCESS: No behavior change
>=> SUCCESS: The string is on the template
>5. Sign off :-D
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++++
> reserve/request.pl                                         | 3 +--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index cdf8b396d35..2a9c08853f8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -686,7 +686,11 @@
>                                                         [% END %]
>                                                     </td>
>                                                     <td>
>+                                                    [% IF itemloo.any_pickup_location %]
>+                                                        Any library
>+                                                    [% ELSE %]
>                                                         [% itemloo.pickup_locations | html %]
>+                                                    [% END %]
>                                                     </td>
>                                                 </tr>
>                                             [% END # / UNLESS itemloo.hide %]
>diff --git a/reserve/request.pl b/reserve/request.pl
>index b7b09f77acf..ec0c67b9b4b 100755
>--- a/reserve/request.pl
>+++ b/reserve/request.pl
>@@ -569,8 +569,7 @@ foreach my $biblionumber (@biblionumbers) {
>                     $item->{available} = 1;
>                     $num_available++;
>                     if($branchitemrule->{'hold_fulfillment_policy'} eq 'any' ) {
>-                        $item->{pickup_locations} = 'Any library';
>-                        $item->{pickup_locations_code} = 'all';
>+                        $item->{any_pickup_location} = 1;
>                     } else {
>                         my $arr_locations = Koha::Items->find($itemnumber)
>                                     ->pickup_locations( { patron => $patron } )->as_list();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 26999: 118228 | 118230 | 118233 | 118234 | 118814 | 118815