Bugzilla – Attachment 118291 Details for
Bug 27964
Link to subscription in serial collections view is broken - the field subscriptionid is undefined in the subscription object.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27964: Don't use wildcards for subscriptionhistory table in subscription queries
Bug-27964-Dont-use-wildcards-for-subscriptionhisto.patch (text/plain), 2.16 KB, created by
Andreas Jonsson
on 2021-03-16 10:22:51 UTC
(
hide
)
Description:
Bug 27964: Don't use wildcards for subscriptionhistory table in subscription queries
Filename:
MIME Type:
Creator:
Andreas Jonsson
Created:
2021-03-16 10:22:51 UTC
Size:
2.16 KB
patch
obsolete
>From 491978abc3f2f40696cdaf4b9591fe62d4ef7456 Mon Sep 17 00:00:00 2001 >From: Andreas Jonsson <andreas.jonsson@kreablo.se> >Date: Tue, 16 Mar 2021 10:21:19 +0000 >Subject: [PATCH] Bug 27964: Don't use wildcards for subscriptionhistory table > in subscription queries > >--- > C4/Serials.pm | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 35983d67db..3a14a0e1eb 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -254,13 +254,14 @@ sub GetSubscription { > my ($subscriptionid) = @_; > my $dbh = C4::Context->dbh; > my $query = qq( >- SELECT subscription.*, >- subscriptionhistory.*, >+ SELECT >+ subscription.*, >+ histstartdate, histenddate, missinglist, recievedlist, opacnote, librariannote, > aqbooksellers.name AS aqbooksellername, > biblio.title AS bibliotitle, > subscription.biblionumber as bibnum > FROM subscription >- LEFT JOIN subscriptionhistory ON subscription.subscriptionid=subscriptionhistory.subscriptionid >+ LEFT JOIN subscriptionhistory USING(subscriptionid) > LEFT JOIN aqbooksellers ON subscription.aqbooksellerid=aqbooksellers.id > LEFT JOIN biblio ON biblio.biblionumber=subscription.biblionumber > WHERE subscription.subscriptionid = ? >@@ -408,11 +409,11 @@ sub GetSubscriptionsFromBiblionumber { > my $query = qq( > SELECT subscription.*, > branches.branchname, >- subscriptionhistory.*, >+ histstartdate, histenddate, missinglist, recievedlist, opacnote, librariannote, > aqbooksellers.name AS aqbooksellername, > biblio.title AS bibliotitle > FROM subscription >- LEFT JOIN subscriptionhistory ON subscription.subscriptionid=subscriptionhistory.subscriptionid >+ LEFT JOIN subscriptionhistory USING(subscriptionid) > LEFT JOIN aqbooksellers ON subscription.aqbooksellerid=aqbooksellers.id > LEFT JOIN biblio ON biblio.biblionumber=subscription.biblionumber > LEFT JOIN branches ON branches.branchcode=subscription.branchcode >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27964
: 118291