Bugzilla – Attachment 118359 Details for
Bug 27933
Order patron search broken (dateofbirth, cardnumber, expirationdate)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27933: Fix patron search result ordering
Bug-27933-Fix-patron-search-result-ordering.patch (text/plain), 2.88 KB, created by
Jonathan Druart
on 2021-03-17 09:17:06 UTC
(
hide
)
Description:
Bug 27933: Fix patron search result ordering
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-03-17 09:17:06 UTC
Size:
2.88 KB
patch
obsolete
>From 2edd7b5b784f5846fae897e653a3960c2ff392b0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 17 Mar 2021 10:14:43 +0100 >Subject: [PATCH] Bug 27933: Fix patron search result ordering > >On bug 27715 we restrict the order by dt params for security reasons. >However in some cases the param passed is "columnname" instead of >"table.columnname". >We should make sure the table is part of the sort fieldname. > >Test plan: >Do a "normal" patron search (from the patrons home page) and another >patron search (guarantor for instance). >Sort by cardnumber, date of birth, expiration date, asc, desc and >confirm it works as expected. >--- > .../prog/en/modules/common/patron_search.tt | 9 +++++++++ > .../intranet-tmpl/prog/en/modules/members/member.tt | 8 +++++++- > 2 files changed, 16 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >index ef285dd0ed..1772d97f3e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt >@@ -153,6 +153,15 @@ > },{ > 'name': 'name_sorton', > 'value': 'borrowers.surname borrowers.firstname' >+ },{ >+ 'name': 'cardnumber_sorton', >+ 'value': 'borrowers.cardnumber', >+ },{ >+ 'name': 'dateofbirth_sorton', >+ 'value': 'borrowers.dateofbirth', >+ },{ >+ 'name': 'dateexpiry_sorton', >+ 'value': 'borrowers.dateexpiry', > },{ > 'name': 'category_sorton', > 'value': 'categories.description', >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 2ab9c823a2..f039dd2375 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -398,8 +398,14 @@ > 'name': 'name_sorton', > 'value': 'borrowers.surname borrowers.firstname' > },{ >- 'name': 'dateofbirth', >+ 'name': 'cardnumber_sorton', >+ 'value': 'borrowers.cardnumber', >+ },{ >+ 'name': 'dateofbirth_sorton', > 'value': 'borrowers.dateofbirth', >+ },{ >+ 'name': 'dateexpiry_sorton', >+ 'value': 'borrowers.dateexpiry', > },{ > 'name': 'category_sorton', > 'value': 'categories.description', >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27933
:
118359
|
118360
|
118413
|
118457