Bugzilla – Attachment 11839 Details for
Bug 5357
Subscription search and displays
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5357: Follow-up - layout and EAN search
Bug-5357-Follow-up---layout-and-EAN-search.patch (text/plain), 3.09 KB, created by
Jonathan Druart
on 2012-08-27 08:39:35 UTC
(
hide
)
Description:
Bug 5357: Follow-up - layout and EAN search
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-08-27 08:39:35 UTC
Size:
3.09 KB
patch
obsolete
>From 828eab7214d028db5151e5ced81ae0900da3b3d9 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sat, 25 Aug 2012 23:18:08 +0200 >Subject: [PATCH] Bug 5357: Follow-up - layout and EAN search > >1) EAN search should be hidden if marcflavour is not UNIMARC >2) Fixes layout to match the advanced search in acquisitions >- labels in front of the fields instead of separate lines >- adds a legend to the form and moves the toggle for the search form to it > >To test: >- EAN search field should only show up when marcflavour system preference > is set to UNIMARC >- Check layout is consistent and you like it >- Check toggle for advanced search still behaves the same > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > .../intranet-tmpl/prog/en/modules/serials/serials-search.tt | 10 ++++++---- > serials/serials-search.pl | 2 +- > 2 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index a8b8399..b5e7f54 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -37,11 +37,11 @@ > > <div id="advsearch"> > <form action="/cgi-bin/koha/serials/serials-search.pl" method="get"> >- <fieldset class="brief"> >+ <fieldset class="rows"> >+ <legend onclick="$('#advsearch_form').slideToggle(400);"> >+ <a id="unfold_advsearch" style="cursor:pointer">Search subscriptions</a> >+ </legend> > [% IF ( done_searched ) %] >- <div onclick="$('#advsearch_form').slideToggle(400);" style="width:100%;"> >- <a id="unfold_advsearch" style="cursor:pointer">Advanced search</a> >- </div> > <div id="advsearch_form" style="display:none"> > [% ELSE %] > <div> >@@ -55,10 +55,12 @@ > <label for="title">Title:</label> > <input type="text" id="title" name="title_filter" value="[% title_filter %]" /> > </li> >+ [% IF ( marcflavour == "UNIMARC" ) %] > <li> > <label for="ean">EAN:</label> > <input type="text" id="ean" name="EAN_filter" value="[% EAN_filter %]" /> > </li> >+ [% END %] > <li> > <label for="publisher">Publisher:</label> > <input type="text" id="publisher" name="publisher_filter" value="[% publisher_filter %]" /> >diff --git a/serials/serials-search.pl b/serials/serials-search.pl >index 0da19d0..e0320fc 100755 >--- a/serials/serials-search.pl >+++ b/serials/serials-search.pl >@@ -104,7 +104,7 @@ $template->param( > branches_loop => \@branches_loop, > done_searched => $searched, > routing => $routing, >- (uc(C4::Context->preference("marcflavour"))) => 1 >+ marcflavour => (uc(C4::Context->preference("marcflavour"))) > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5357
:
10433
|
11263
|
11264
|
11265
|
11266
|
11287
|
11290
|
11736
|
11831
|
11832
| 11839