Attachment 118428 Details for Bug 27967 – Bug 27967: Add min attribute to borraccount modals

[patch] Bug 27967: Add min attribute to borraccount modals

Bug-27967-Add-min-attribute-to-borraccount-modals.patch (text/plain), 2.29 KB, created by Tomás Cohen Arazi (tcohen) on 2021-03-17 17:43:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2021-03-17 17:43:10 UTC

Size: 2.29 KB

patch

obsolete

>From 16c29c7599c3342383b054e2597810c220b5f0a7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 16 Mar 2021 16:39:13 +0000
>Subject: [PATCH] Bug 27967: Add min attribute to borraccount modals
>
>This patch adds a min attribute to the form fields of the borrower
>account page modals to prevent negative values being entered
>inappropriately.
>
>Test plan
>1/ Trigger the refund modal from the borrower account page.
>2/ Attempt to enter a negative value for the amount to refund and note
>with the patch applied you face a validation error (without the patch,
>upon submission of a negative value you will be faced with a server side
>error)
>3/ Trigger the discount modal from the borrower account page.
>4/ Attempt to enter a negative value for the amount to discount and note
>with the patch applied you face a validation error (without the patch,
>upon submission of a negative value you will be faced with a server side
>error)
>5/ Signoff
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>index a742d0ddbb1..971ff4f41c5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>@@ -387,7 +387,7 @@
>                 var amountoutstanding = button.data('amountoutstanding');
>                 var paid = amount - amountoutstanding;
>                 $("#paid + span").replaceWith(paid);
>-                $("#returned").attr({ "value": paid, "max": paid });
>+                $("#returned").attr({ "value": paid, "max": paid, "min": 0 });
>                 $("#returned, #refund_transaction_type").focus();
>             });
> 
>@@ -399,7 +399,7 @@
>                 $('#discountline').val(accountline);
>                 var amount = button.data('amount');
>                 $("#charged + span").replaceWith(amount);
>-                $("#discount").attr({ "max": amount });
>+                $("#discount").attr({ "max": amount, "min": 0 });
>                 $("#discount").focus();
>             });
>         });
>-- 
>2.31.0

Actions: View | Diff | Splinter Review

Attachments on bug 27967: 118339 | 118426 | 118428