Bugzilla – Attachment 118588 Details for
Bug 27993
Koha::Item::Transfer->in_transit should not count cancelled transfers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27993: Add unit tests
Bug-27993-Add-unit-tests.patch (text/plain), 1.39 KB, created by
Joonas Kylmälä
on 2021-03-22 11:32:53 UTC
(
hide
)
Description:
Bug 27993: Add unit tests
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-03-22 11:32:53 UTC
Size:
1.39 KB
patch
obsolete
>From 1d620c8119b0dd42b07d3c95f93a0513383fdc9f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 19 Mar 2021 13:31:10 +0000 >Subject: [PATCH] Bug 27993: Add unit tests >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch adds a unit test to check that 'in_transit' takes >datecancelled into account. > >Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > t/db_dependent/Koha/Item/Transfer.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Item/Transfer.t b/t/db_dependent/Koha/Item/Transfer.t >index c2bdd2cb7d..22b82be628 100755 >--- a/t/db_dependent/Koha/Item/Transfer.t >+++ b/t/db_dependent/Koha/Item/Transfer.t >@@ -173,7 +173,7 @@ subtest 'receive tests' => sub { > > subtest 'in_transit tests' => sub { > >- plan tests => 3; >+ plan tests => 4; > > $schema->storage->txn_begin; > >@@ -203,6 +203,8 @@ subtest 'in_transit tests' => sub { > $transfer->datearrived(dt_from_string)->store; > ok( !$transfer->in_transit, 'in_transit returns false when datearrived is defined'); > >+ $transfer->set( { datearrived => undef, datecancelled => dt_from_string } )->store; >+ ok( !$transfer->in_transit, 'in_transit returns false when datecancelled is defined'); > > $schema->storage->txn_rollback; > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27993
:
118539
|
118540
|
118578
|
118586
|
118587
| 118588 |
118589