Bugzilla – Attachment 118589 Details for
Bug 27993
Koha::Item::Transfer->in_transit should not count cancelled transfers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27993: Add handling for datecancelled in in_transit
Bug-27993-Add-handling-for-datecancelled-in-intran.patch (text/plain), 1.18 KB, created by
Joonas Kylmälä
on 2021-03-22 11:32:57 UTC
(
hide
)
Description:
Bug 27993: Add handling for datecancelled in in_transit
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-03-22 11:32:57 UTC
Size:
1.18 KB
patch
obsolete
>From 97eff2909323f14d522b2103d7f5a23405354e8c Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 19 Mar 2021 13:31:49 +0000 >Subject: [PATCH] Bug 27993: Add handling for datecancelled in in_transit >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch adds handling for the datecancelled field in the in_transit >method. > >Test plan >1/ Run the new unit test in t/db_dependent/Koha/Item/Transfer.t > >Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >--- > Koha/Item/Transfer.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/Koha/Item/Transfer.pm b/Koha/Item/Transfer.pm >index 8f4284f53a..96e652df28 100644 >--- a/Koha/Item/Transfer.pm >+++ b/Koha/Item/Transfer.pm >@@ -94,7 +94,9 @@ Boolean returning whether the transfer is in transit or waiting > sub in_transit { > my ($self) = @_; > >- return ( defined( $self->datesent ) && !defined( $self->datearrived ) ); >+ return ( defined( $self->datesent ) >+ && !defined( $self->datearrived ) >+ && !defined( $self->datecancelled ) ); > } > > =head3 receive >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27993
:
118539
|
118540
|
118578
|
118586
|
118587
|
118588
| 118589