Attachment 118658 Details for Bug 26351 – Bug 26351: Clean up includes in Circulation.pm

[patch] Bug 26351: Clean up includes in Circulation.pm

Bug-26351-Clean-up-includes-in-Circulationpm.patch (text/plain), 3.00 KB, created by Kyle M Hall (khall) on 2021-03-23 13:44:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-03-23 13:44:35 UTC

Size: 3.00 KB

patch

obsolete

>From 051bdd026beb2ad06cb8ac7a10e3a246f2d35f20 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 23 Mar 2021 09:38:05 -0400
>Subject: [PATCH] Bug 26351: Clean up includes in Circulation.pm
>
>Circulation.pm has so many includes that the same module
>is getting used multiple times without developers noticing it
>is already beuing used.
>
>This commit separates use lines by namespace and sorts them,
>removing duplicate and unnecessary use lines.
>---
> C4/Circulation.pm | 75 +++++++++++++++++++++++------------------------
> 1 file changed, 37 insertions(+), 38 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 5e5624dbf1..697c6cea6a 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -19,64 +19,63 @@ package C4::Circulation;
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>+
>+use Algorithm::CheckDigits;
>+use Carp;
>+use Data::Dumper;
>+use Date::Calc qw(
>+    Today
>+    Today_and_Now
>+    Add_Delta_YM
>+    Add_Delta_DHMS
>+    Date_to_Days
>+    Day_of_Week
>+    Add_Delta_Days
>+);
> use DateTime;
>+use Encode;
>+use List::MoreUtils qw( uniq any );
> use POSIX qw( floor );
>+use Scalar::Util qw( looks_like_number );
>+use Try::Tiny;
> use YAML::XS;
>-use Encode;
> 
>-use Koha::DateUtils;
>-use C4::Context;
>-use C4::Stats;
>-use C4::Reserves;
>+use C4::Accounts;
> use C4::Biblio;
>+use C4::Context;
>+use C4::Debug;
>+use C4::ItemCirculationAlertPreference;
> use C4::Items;
>+use C4::Log; # logaction
> use C4::Members;
>-use C4::Accounts;
>-use C4::ItemCirculationAlertPreference;
> use C4::Message;
>-use C4::Debug;
>-use C4::Log; # logaction
> use C4::Overdues qw(CalcFine UpdateFine get_chargeable_units);
>+use C4::Reserves;
> use C4::RotatingCollections qw(GetCollectionItemBranches);
>-use Algorithm::CheckDigits;
>+use C4::Stats;
> 
>-use Data::Dumper;
>+use Koha::Account::Lines;
>+use Koha::Account::Offsets;
> use Koha::Account;
> use Koha::AuthorisedValues;
> use Koha::Biblioitems;
>-use Koha::DateUtils;
> use Koha::Calendar;
>+use Koha::Charges::Fees;
>+use Koha::Checkouts::ReturnClaims;
> use Koha::Checkouts;
>+use Koha::Config::SysPrefs;
>+use Koha::Database;
>+use Koha::DateUtils;
>+use Koha::Exceptions::Checkout;
>+use Koha::Holds;
> use Koha::Illrequests;
> use Koha::Items;
>-use Koha::Patrons;
>-use Koha::Patron::Debarments;
>-use Koha::Database;
> use Koha::Libraries;
>-use Koha::Account::Lines;
>-use Koha::Holds;
>-use Koha::Account::Lines;
>-use Koha::Account::Offsets;
>-use Koha::Config::SysPrefs;
>-use Koha::Charges::Fees;
>-use Koha::Config::SysPref;
>-use Koha::Checkouts::ReturnClaims;
>-use Koha::SearchEngine::Indexer;
>-use Koha::Exceptions::Checkout;
>+use Koha::Patron::Debarments;
>+use Koha::Patrons;
> use Koha::Plugins;
>-use Carp;
>-use List::MoreUtils qw( uniq any );
>-use Scalar::Util qw( looks_like_number );
>-use Try::Tiny;
>-use Date::Calc qw(
>-    Today
>-    Today_and_Now
>-    Add_Delta_YM
>-    Add_Delta_DHMS
>-    Date_to_Days
>-    Day_of_Week
>-    Add_Delta_Days
>-);
>+use Koha::SearchEngine::Indexer;
>+
> use vars qw(@ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
> 
> BEGIN {
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26351: 109532 | 109548 | 109671 | 110844 | 110846 | 111575 | 111577 | 111578 | 111579 | 111862 | 111863 | 111894 | 111916 | 111917 | 111918 | 111919 | 111920 | 111921 | 111922 | 113571 | 113572 | 113573 | 113574 | 113575 | 113576 | 113577 | 113578 | 115172 | 115173 | 115174 | 115175 | 115176 | 115177 | 115178 | 115179 | 115180 | 118649 | 118650 | 118651 | 118652 | 118653 | 118654 | 118655 | 118656 | 118657 | 118658 | 118681 | 118682 | 118683 | 118684 | 118685 | 118686 | 118687 | 118688 | 118689 | 118690 | 122433 | 122434 | 122435 | 122436 | 122437 | 122438 | 122439 | 122440 | 122441 | 122442 | 124258 | 124259 | 124260 | 124261 | 124262 | 124263 | 124264 | 124265 | 124266 | 124313 | 125447 | 125763 | 125764 | 125765