Bugzilla – Attachment 118667 Details for
Bug 28023
Typo in Reply-To header
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28023: Fix Reply-To typo
Bug-28023-Fix-Reply-To-typo.patch (text/plain), 1.05 KB, created by
Martin Renvoize (ashimema)
on 2021-03-23 14:31:36 UTC
(
hide
)
Description:
Bug 28023: Fix Reply-To typo
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-03-23 14:31:36 UTC
Size:
1.05 KB
patch
obsolete
>From 25821e6e4c69168f1e3bc9c55d1dae3023347bdb Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 23 Mar 2021 11:14:43 -0300 >Subject: [PATCH] Bug 28023: Fix Reply-To typo > >This patch fixes a typo making the header useless. > >To test: >1. Apply the regression tests patch >2. Run: > $ kshell > k$ prove t/Koha/Email.t >=> FAIL: The Reply-To header is not being set! >3. Apply this patch >4. Repeat 2 >=> SUCCESS: Tests pass! the header is set! >5. Sign off :-D > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Email.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Email.pm b/Koha/Email.pm >index e91a49e402..c111839d3c 100644 >--- a/Koha/Email.pm >+++ b/Koha/Email.pm >@@ -118,7 +118,7 @@ sub create { > > my $email = $self->SUPER::new( $args ); > >- $email->header( 'ReplyTo', $addresses->{reply_to} ) >+ $email->header( 'Reply-To', $addresses->{reply_to} ) > if $addresses->{reply_to}; > > $email->header( 'Sender' => $addresses->{sender} ) if $addresses->{sender}; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28023
:
118661
|
118662
|
118666
| 118667