Attachment 118698 Details for Bug 28017 – Bug 28017: Test IPs are supported

[patch] Bug 28017: Test IPs are supported

Bug-28017-Test-IPs-are-supported.patch (text/plain), 1.36 KB, created by Kyle M Hall (khall) on 2021-03-23 16:59:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-03-23 16:59:53 UTC

Size: 1.36 KB

patch

obsolete

>From 87e783b191c598559998d1b63b752ce6fe4ec2c9 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 23 Mar 2021 12:19:48 -0300
>Subject: [PATCH] Bug 28017: Test IPs are supported
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/Koha/Email.t | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/Koha/Email.t b/t/Koha/Email.t
>index bfd75929d2..2b78216500 100755
>--- a/t/Koha/Email.t
>+++ b/t/Koha/Email.t
>@@ -26,7 +26,7 @@ use_ok('Koha::Email');
> 
> subtest 'create() tests' => sub {
> 
>-    plan tests => 24;
>+    plan tests => 25;
> 
>     t::lib::Mocks::mock_preference( 'SendAllEmailsTo', undef );
> 
>@@ -62,13 +62,14 @@ subtest 'create() tests' => sub {
> 
>     $email = Koha::Email->create(
>         {
>-            from        => 'from@example.com',
>+            from        => 'from@8.8.8.8',
>             to          => 'to@example.com',
>             bcc         => 'root@localhost',
>         }
>     );
> 
>     is( $email->email->header('Bcc'), 'root@localhost', 'Non-FQDN (@localhost) supported' );
>+    is( $email->email->header('From'), 'from@8.8.8.8', 'IPs supported' );
> 
>     t::lib::Mocks::mock_preference( 'SendAllEmailsTo', 'catchall@example.com' );
>     t::lib::Mocks::mock_preference( 'ReplytoDefault', 'replytodefault@example.com' );
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 28017: 118620 | 118621 | 118622 | 118644 | 118645 | 118646 | 118668 | 118696 | 118697 | 118698 | 119208