Bugzilla – Attachment 118703 Details for
Bug 27963
touch_all_items.pl script is not working at all
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27963: (bug 23463 follow-up) Fix touch_all_items.pl
Bug-27963-bug-23463-follow-up-Fix-touchallitemspl.patch (text/plain), 1.57 KB, created by
Martin Renvoize (ashimema)
on 2021-03-23 18:17:37 UTC
(
hide
)
Description:
Bug 27963: (bug 23463 follow-up) Fix touch_all_items.pl
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-03-23 18:17:37 UTC
Size:
1.57 KB
patch
obsolete
>From d8cf223084c26d11e979b12c7ddf1e7c3cb9daa4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 16 Mar 2021 11:36:17 +0100 >Subject: [PATCH] Bug 27963: (bug 23463 follow-up) Fix touch_all_items.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This script is used to fix inconsistencies in the items table. Prior to >bug 23463, ModItem dealt with that. > >We need to make some attributes as dirty to make sure the >Koha::Item->store method will fix them. > >Test plan: >Be familiar with how touch_all_items is supposed to work and confirm >that the different inconsistencies are fixed. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > misc/maintenance/touch_all_items.pl | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > >diff --git a/misc/maintenance/touch_all_items.pl b/misc/maintenance/touch_all_items.pl >index 648190502e..dbf1609221 100755 >--- a/misc/maintenance/touch_all_items.pl >+++ b/misc/maintenance/touch_all_items.pl >@@ -83,8 +83,15 @@ $sth_fetch->execute(); > > # fetch info from the search > while (my ($biblionumber, $itemnumber, $itemcallnumber) = $sth_fetch->fetchrow_array){ >- >- eval { Koha::Items->find($itemnumber)->itemcallnumber($itemcallnumber)->store; }; >+ >+ my $item = Koha::Items->find($itemnumber); >+ next unless $item; >+ >+ for my $c (qw( itemcallnumber cn_source ) ){ >+ $item->make_column_dirty($c); >+ } >+ >+ eval { $item->store }; > my $modok = $@ ? 0 : 1; > > if ($modok) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27963
:
118294
|
118328
|
118333
|
118334
| 118703