Attachment 118791 Details for Bug 28007 – Bug 28007: (follow-up) Address missing instances

[patch] Bug 28007: (follow-up) Address missing instances

Bug-28007-follow-up-Address-missing-instances.patch (text/plain), 4.03 KB, created by Owen Leonard on 2021-03-25 12:49:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-03-25 12:49:38 UTC

Size: 4.03 KB

patch

obsolete

>From 7135f1294213149725af661d2269b3b0da1625cb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 25 Mar 2021 12:47:41 +0000
>Subject: [PATCH] Bug 28007: (follow-up) Address missing instances
>
>This patch removes the "title-string" option from some dataTable
>initializations.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt    | 3 +--
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt    | 7 +------
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt | 1 -
> koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js             | 3 +--
> 4 files changed, 3 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt
>index 037f60d523..6155da023f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt
>@@ -64,8 +64,7 @@
>         $(document).ready(function() {
>             $("#files").dataTable($.extend(true, {}, dataTablesDefaults, {
>                 "aoColumnDefs": [
>-                    { "aTargets": [ -1 ], "asSorting" : [ "desc", "asc" ], "bSearchable": false },
>-                    { "sType": "title-string", "aTargets" : [ "title-string" ] }
>+                    { "aTargets": [ -1 ], "asSorting" : [ "desc", "asc" ], "bSearchable": false }
>                 ],
>                 "bPaginate": false
>             }));
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>index 7d9ea672c8..5ac0a41b92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>@@ -344,14 +344,9 @@
>             [% IF borrowers %]
>                 $("#borrowerst").dataTable($.extend(true, {}, dataTablesDefaults, {
>                     "sDom": 't',
>-                    [% IF ( op == 'show_results' ) %]
>-                        "aoColumnDefs": [
>-                            { 'sType': "title-string", 'aTargets' : [ 'title-string'] }
>-                        ],
>-                    [% ELSE %]
>+                    [% UNLESS ( op == 'show_results' ) %]
>                         "aoColumnDefs": [
>                             { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false },
>-                            { 'sType': "title-string", 'aTargets' : [ 'title-string'] }
>                         ],
>                     [% END %]
>                     "bPaginate": false
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt
>index 14a67e81d3..c19b317460 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt
>@@ -138,7 +138,6 @@
>                 "order": [[ 1, "asc" ]],
>                 "aoColumnDefs": [
>                     { "orderable": false, "searchable": false, 'targets': [ 'NoSort' ] },
>-                    { "type": "title-string", "targets" : [ "title-string" ] },
>                     { "type": "anti-the", "targets": [ "anti-the" ] }
>                 ],
>                 "pagingType": "full"
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js b/koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js
>index f5ee5245d2..fb790551bd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js
>@@ -62,8 +62,7 @@ $(document).ready(function() {
>     $("#tagst").dataTable($.extend(true, {}, dataTablesDefaults, {
>         "aoColumnDefs": [
>             { "bSortable": false, "bSearchable": false, 'aTargets': [ 'NoSort' ] },
>-            { "sType": "anti-the", "aTargets" : [ "anti-the" ] },
>-            { "sType": "title-string", "aTargets" : [ "title-string" ] }
>+            { "sType": "anti-the", "aTargets" : [ "anti-the" ] }
>         ],
>         "aaSorting": [[ 2, "desc" ]],
>         "sPaginationType": "full"
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28007: 118618 | 118671 | 118791 | 118897 | 118898