Attachment 118796 Details for Bug 21958 – Bug 21958: (QA follow-up) Correct indirect object notation

[patch] Bug 21958: (QA follow-up) Correct indirect object notation

Bug-21958-QA-follow-up-Correct-indirect-object-not.patch (text/plain), 1.12 KB, created by Martin Renvoize (ashimema) on 2021-03-25 13:38:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-25 13:38:19 UTC

Size: 1.12 KB

patch

obsolete

>From 00dfed0603a6b24e66155e753fd76000d7dbc18c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 25 Mar 2021 13:32:39 +0000
>Subject: [PATCH] Bug 21958: (QA follow-up) Correct indirect object notation
>
>Our coding guidelines now forbit indirect object notation calling.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/AuthoritiesMarc/MARC21.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/AuthoritiesMarc/MARC21.t b/t/db_dependent/AuthoritiesMarc/MARC21.t
>index 77047e4bbc..d8ccde0d3f 100755
>--- a/t/db_dependent/AuthoritiesMarc/MARC21.t
>+++ b/t/db_dependent/AuthoritiesMarc/MARC21.t
>@@ -28,7 +28,7 @@ subtest 'CompareFieldWithAuthority tests' => sub {
> 
>     # We are now going to be testing the authorities hierarchy code, and
>     # therefore need to pretend that we have consistent data in our database
>-    my $module = new Test::MockModule('C4::AuthoritiesMarc');
>+    my $module = Test::MockModule->new('C4::AuthoritiesMarc');
>     $module->mock('GetHeaderAuthority', sub {
>         return {'authtrees' => ''};
>     });
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21958: 84283 | 91150 | 92611 | 99528 | 108182 | 114303 | 118795 | 118796 | 119217