Bugzilla – Attachment 118808 Details for
Bug 27936
AllowItemsOnHoldCheckoutSIP does not allow checkout of items currently waiting for a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text
Bug-27936-Clarify-AllowItemsOnHoldCheckoutSIP-sysp.patch (text/plain), 3.33 KB, created by
Martin Renvoize (ashimema)
on 2021-03-25 14:02:17 UTC
(
hide
)
Description:
Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help text
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-03-25 14:02:17 UTC
Size:
3.33 KB
patch
obsolete
>From 9037c0d4f5178db44c7d88e0922904e37729424c Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 17 Mar 2021 13:27:27 +0200 >Subject: [PATCH] Bug 27936: Clarify AllowItemsOnHoldCheckoutSIP syspref help > text > >The waiting reserves have always been impossible to checkout via >SIP2. There was some confusion whether this is actually true but if >you check the commit "Bug 25690: Remove duplicated logic in SIP2 >checkouts" (338ba1d769) and the removed code around line > > $self->screen_msg("Item is on hold for another patron."); > >you will be sure that it has been impossible to checkout waiting holds. > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > installer/data/mysql/mandatory/sysprefs.sql | 2 +- > .../prog/en/modules/admin/preferences/circulation.pref | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql >index 1034313061..c48ad18d60 100644 >--- a/installer/data/mysql/mandatory/sysprefs.sql >+++ b/installer/data/mysql/mandatory/sysprefs.sql >@@ -29,7 +29,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AllowHoldsOnDamagedItems','1','','Allow hold requests to be placed on damaged items','YesNo'), > ('AllowHoldsOnPatronsPossessions','1',NULL,'Allow holds on records that patron have items of it','YesNo'), > ('AllowCheckoutNotes', '0', NULL, 'Allow patrons to submit notes about checked out items.','YesNo'), >-('AllowItemsOnHoldCheckoutSIP','0','','Do not generate RESERVE_WAITING and RESERVED warning when checking out items reserved to someone else via SIP. This allows self checkouts for those items.','YesNo'), >+('AllowItemsOnHoldCheckoutSIP','0','','Do not generate RESERVED warning when checking out items reserved to someone else via SIP. This allows self checkouts for those items.','YesNo'), > ('AllowItemsOnHoldCheckoutSCO','0','','Do not generate RESERVE_WAITING and RESERVED warning in the SCO module when checking out items reserved to someone else. This allows self checkouts for those items.','YesNo'), > ('AllowMultipleCovers','0','1','Allow multiple cover images to be attached to each bibliographic record.','YesNo'), > ('AllowMultipleIssuesOnABiblio',1,'Allow/Don\'t allow patrons to check out multiple items from one biblio','','YesNo'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 9acc59f50e..157bbea997 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -218,7 +218,7 @@ Circulation: > 1: Allow > 0: "Don't allow" > - checkouts of items reserved to someone else via SIP checkout messages. >- - If allowed do not generate RESERVE_WAITING and RESERVED warning. >+ - If allowed do not generate RESERVED warning. > - This allows self checkouts for those items. If using the holds queue items with pending holds will be marked as "unavailable" if this set to "Don't allow". > - > - pref: AllowItemsOnHoldCheckoutSCO >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27936
:
118366
|
118367
|
118455
|
118458
| 118808