Attachment 118817 Details for Bug 28003 – Bug 28003: Invoice adjustments using inactive budgets do not indicate that status

[patch] Bug 28003: Invoice adjustments using inactive budgets do not indicate that status

Bug-28003-Invoice-adjustments-using-inactive-budge.patch (text/plain), 2.24 KB, created by Martin Renvoize (ashimema) on 2021-03-25 14:46:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-25 14:46:07 UTC

Size: 2.24 KB

patch

obsolete

>From 32f1fdc2e1c350b53948f7241d6d0259d96a63e1 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 19 Mar 2021 15:02:12 +0000
>Subject: [PATCH] Bug 28003: Invoice adjustments using inactive budgets do not
> indicate that status
>
>This patch affects the display of existing invoice adjustments to indicate when using an inactive budget
>
>To recreate
>1 - In acquisitions go to a vendor
>2 - Click 'Receive'
>3 - Create an invoice
>4 - Finish receiving
>5 - Go to Admin->budgets
>6 - Duplicate your current budget
>7 - Mark the original budget inactive
>8 - View the invoice you created
>9 - No indication the budget is inactive
>10 - Apply patch
>11 - Reload the page
>12 - The fund shows '(inactive)'
>13 - The dropdown to edit the funds also indicates which funds are inactive
>
>Note that adding new adjustments does show only the active budget unless you request to see inactive.
>
>Signed-off-by: Amit Gupta <amitddng135@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index 6638449a4b..52b586bdbb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -205,7 +205,11 @@
>                                                   [% ELSE %]
>                                                       <option value="[% budget.b_id | html %]">
>                                                   [% END %]
>-                                                  [% budget.b_txt | html %]
>+                                                  [% IF budget.b_active %]
>+                                                      [% budget.b_txt | html %]
>+                                                  [% ELSE %]
>+                                                      [% budget.b_txt | html %] (inactive)
>+                                                  [% END %]
>                                                   </option>
>                                               [% END %]
>                                           </select>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28003: 118549 | 118711 | 118817