Attachment 118871 Details for Bug 28036 – Bug 28036: Improve breadcrumbs of serial claims page

[patch] Bug 28036: Improve breadcrumbs of serial claims page

Bug-28036-Improve-breadcrumbs-of-serial-claims-pag.patch (text/plain), 3.10 KB, created by Lucas Gass (lukeg) on 2021-03-26 17:13:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2021-03-26 17:13:06 UTC

Size: 3.10 KB

patch

obsolete

>From 8d2860ed6129055bd97fe6c6d8c86ec57e56b11d Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 25 Mar 2021 18:05:13 +0000
>Subject: [PATCH] Bug 28036: Improve breadcrumbs of serial claims page
>
>This patch modifies the serial claims script and templates so that
>better context can be shown in the page title and page breadcrumbs when
>a vendor has been selected.
>
>To test, apply the patch and go to Serials -> Claims.
>
>- The initial state of the page title and breadcrumbs should show
>  "Serials > Claims."
>- Select a vendor. The page title and breadcrumbs show show "Serials >
>  Claims > Claims for <vendor name>."
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../prog/en/modules/serials/claims.tt              | 25 ++++++++++++++++------
> serials/claims.pl                                  |  2 ++
> 2 files changed, 20 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>index a2dd7fec89..a9cffd0b70 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
>@@ -4,7 +4,7 @@
> [% USE Branches %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>-    <title>Koha &rsaquo; Serials &rsaquo; Claims</title>
>+    <title>Koha &rsaquo; Serials &rsaquo; Claims [% IF ( supplierid ) -%] &rsaquo; Claims for [% suppliername | html %] [% END %]</title>
>     [% INCLUDE 'doc-head-close.inc' %]
> </head>
> 
>@@ -20,11 +20,22 @@
>         <li>
>             <a href="/cgi-bin/koha/serials/serials-home.pl">Serials</a>
>         </li>
>-        <li>
>-            <a href="#" aria-current="page">
>-                Claims
>-            </a>
>-        </li>
>+        [% IF ( supplierid ) -%]
>+            <li>
>+                <a href="/cgi-bin/koha/serials/claims.pl">
>+                    Claims
>+                </a>
>+            </li>
>+            <li>
>+                <a href="#" aria-current="page">Claims for [% suppliername | html %]</a>
>+            </li>
>+        [% ELSE -%]
>+            <li>
>+                <a href="#" aria-current="page">
>+                    Claims
>+                </a>
>+            </li>
>+        [% END %]
>     </ol>
> </nav>
> 
>@@ -33,7 +44,7 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>-    <h1>Claims</h1>
>+    <h1>Claims [% IF ( suppliername ) %] for [% suppliername | html %] [% END %]</h1>
> 
>     [% IF error_claim %]
>         [% IF error_claim == 'no_vendor_email' %]
>diff --git a/serials/claims.pl b/serials/claims.pl
>index 4c6a2728a9..498f1cc2d9 100755
>--- a/serials/claims.pl
>+++ b/serials/claims.pl
>@@ -84,11 +84,13 @@ my $letters = GetLetters({ module => 'claimissues' });
> 
> my @missingissues;
> if ($supplierid) {
>+    my $supplier = Koha::Acquisition::Booksellers->find( $supplierid );
>     @missingissues = GetLateOrMissingIssues($supplierid);
>     foreach my $issue (@missingissues) {
>         $issue->{cannot_claim} = 1
>           unless C4::Serials::can_claim_subscription($issue);
>     }
>+    $template->param( suppliername => $supplier->name );
> }
> 
> $template->param(
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28036: 118835 | 118871 | 118913