Attachment 118878 Details for Bug 24000 – Bug 24000: Some modules do not return 1

[patch] Bug 24000: Some modules do not return 1

Bug-24000-Some-modules-do-not-return-1.patch (text/plain), 2.83 KB, created by David Nind on 2021-03-26 18:54:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2021-03-26 18:54:17 UTC

Size: 2.83 KB

patch

obsolete

>From db8ad7a36cb99b8c9496cd3678798d55b423e37f Mon Sep 17 00:00:00 2001
>From: James O'Keeffe <jamespfk@gmail.com>
>Date: Tue, 19 Jan 2021 03:16:45 +0000
>Subject: [PATCH] Bug 24000: Some modules do not return 1
>
>This patch adds "1;" to the end of the following perl files:
>Koha/Filter/MARC/EmbedItemsAvailability.pm
>Koha/Filter/MARC/EmbedSeeFromHeadings.pm
>Koha/Filter/MARC/Null.pm
>Koha/Item/Search/Field.pm
>Koha/SearchEngine.pm
>misc/translator/VerboseWarnings.pm
>t/lib/Koha/Plugin/Test.pm
>
>This indicates the succesful execution of the initialization code.
>
>Test plan:
>Ensure that there are no other perl files that need "1;", but dont have
>it.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/Filter/MARC/EmbedItemsAvailability.pm | 2 ++
> Koha/Filter/MARC/EmbedSeeFromHeadings.pm   | 2 ++
> Koha/Filter/MARC/Null.pm                   | 2 ++
> Koha/SearchEngine.pm                       | 2 ++
> misc/translator/VerboseWarnings.pm         | 2 ++
> t/lib/Koha/Plugin/Test.pm                  | 2 ++
> 6 files changed, 12 insertions(+)
>
>diff --git a/Koha/Filter/MARC/EmbedItemsAvailability.pm b/Koha/Filter/MARC/EmbedItemsAvailability.pm
>index c3bb4a3d16..ac4eaee1d4 100644
>--- a/Koha/Filter/MARC/EmbedItemsAvailability.pm
>+++ b/Koha/Filter/MARC/EmbedItemsAvailability.pm
>@@ -95,3 +95,5 @@ sub _processrecord {
> 
>     return $record;
> }
>+
>+1;
>diff --git a/Koha/Filter/MARC/EmbedSeeFromHeadings.pm b/Koha/Filter/MARC/EmbedSeeFromHeadings.pm
>index fa8472022d..9ed7b45bea 100644
>--- a/Koha/Filter/MARC/EmbedSeeFromHeadings.pm
>+++ b/Koha/Filter/MARC/EmbedSeeFromHeadings.pm
>@@ -105,3 +105,5 @@ sub _processrecord {
>     }
>     return $record;
> }
>+
>+1;
>diff --git a/Koha/Filter/MARC/Null.pm b/Koha/Filter/MARC/Null.pm
>index 476630ccef..dc5a016934 100644
>--- a/Koha/Filter/MARC/Null.pm
>+++ b/Koha/Filter/MARC/Null.pm
>@@ -52,3 +52,5 @@ sub filter {
> 
>     return $record;
> }
>+
>+1;
>diff --git a/Koha/SearchEngine.pm b/Koha/SearchEngine.pm
>index d2d58bbb35..7aa1f85a6d 100644
>--- a/Koha/SearchEngine.pm
>+++ b/Koha/SearchEngine.pm
>@@ -44,3 +44,5 @@ indicate that you want to be working with the authorities index.
> # may be used for, e.g., directory names.
> Readonly our $BIBLIOS_INDEX     => 'biblios';
> Readonly our $AUTHORITIES_INDEX => 'authorities';
>+
>+1;
>diff --git a/misc/translator/VerboseWarnings.pm b/misc/translator/VerboseWarnings.pm
>index 8d6d1cf0e8..65281ffcb1 100644
>--- a/misc/translator/VerboseWarnings.pm
>+++ b/misc/translator/VerboseWarnings.pm
>@@ -123,4 +123,6 @@ sub warned {
>     return $warned; # number of times warned
> }
> 
>+1;
>+
> ###############################################################################
>diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm
>index 0a92967738..1c296b0595 100644
>--- a/t/lib/Koha/Plugin/Test.pm
>+++ b/t/lib/Koha/Plugin/Test.pm
>@@ -311,3 +311,5 @@ sub intranet_catalog_biblio_tab {
> sub _private_sub {
>     return "";
> }
>+
>+1;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24000: 95199 | 115290 | 118877 | 118878 | 118891 | 118892