Attachment 118914 Details for Bug 27991 – Bug 27991: Message field for OPAC problem reporting should have a maxlength set

[patch] Bug 27991: Message field for OPAC problem reporting should have a maxlength set

Bug-27991-Message-field-for-OPAC-problem-reporting.patch (text/plain), 2.87 KB, created by Katrin Fischer on 2021-03-27 17:03:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-03-27 17:03:27 UTC

Size: 2.87 KB

patch

obsolete

>From ae93b7ef2fdd12abb49377a6f8126924fda86bd8 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 18 Mar 2021 17:59:15 +0000
>Subject: [PATCH] Bug 27991: Message field for OPAC problem reporting should
> have a maxlength set
>
>This patch adds a maxlength attribute to the form field for entering
>checkout notes in the OPAC, matching the character limit of the database
>column. A note is added to show the 255 character limit.
>
>To test, apply the patch and enable the AllowCheckoutNotes system
>preference.
>
> - Log in to the OPAC as a user who has checkouts.
> - On the "Your summary" page, the "Report a problem" fields should
>   have a hint below them, "255 characters maximum."
> - Try entering text in one of the fields. You should not be able to
>   enter more than 255 characters:
>
>   Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse
>   nunc mi, fringilla in mauris quis, hendrerit feugiat mi. Sed ultrices
>   mollis nulla sit amet faucibus. Sed volutpat augue risus, eu rutrum
>   eros commodo eu. Proin rhoncus nisi vitae magna_
>
> - Test that your submission is saved correctly.
>
>Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>index 5d4206a0c6..fd8fd0abe4 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
>@@ -441,7 +441,8 @@
>                                                 [% END %]
>                                                 [% IF ( Koha.Preference('AllowCheckoutNotes') ) %]
>                                                     <td class="note">
>-                                                        <input type="text" name="note" data-issue_id="[% ISSUE.issue_id | html %]" data-origvalue="[% ISSUE.note | html %]" value="[% ISSUE.note | html %]" readonly>
>+                                                        <input type="text" name="note" data-issue_id="[% ISSUE.issue_id | html %]" data-origvalue="[% ISSUE.note | html %]" value="[% ISSUE.note | html %]" maxlength="255" readonly>
>+                                                        <div class="hint">255 characters maximum</div>
>                                                         <button type="button" class="btn btn-primary btn-sm js_submitnote" id="save_[% ISSUE.issue_id | html %]" style="display:none;">Submit note</button>
>                                                         <button type="button" class="btn btn-primary btn-sm nonjs_submitnote" href="/cgi-bin/koha/opac-issue-note.pl?issue_id=[% ISSUE.issue_id | url %]">Edit / Create note</button>
>                                                     </td>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27991: 118469 | 118492 | 118914