Bugzilla – Attachment 118969 Details for
Bug 27817
Enhance display of title information throughout acquisitions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27817: Use biblio-title include in some acquisitions pages
Bug-27817-Use-biblio-title-include-in-some-acquisi.patch (text/plain), 5.65 KB, created by
Owen Leonard
on 2021-03-29 15:17:34 UTC
(
hide
)
Description:
Bug 27817: Use biblio-title include in some acquisitions pages
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-03-29 15:17:34 UTC
Size:
5.65 KB
patch
obsolete
>From fc60929874fb5a328c7f2ea8d4c404ba2b7984b4 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 29 Mar 2021 14:57:22 +0000 >Subject: [PATCH] Bug 27817: Use biblio-title include in some acquisitions > pages > >This patch adds the use of the biblio-title include in acquisitions >templates which get the right data from their corresponding scripts. > >To test, apply the patch and test these Acquisitions pages to confirm >that titles with 245$b, 245$h, etc, show all the correct information. > >- Acquisitions -> Vendor -> Basket >- Acquisitions -> Vendor -> Uncertain prices >- Acquisitions -> Invoices -> Invoice >- Acquisitions -> Invoices -> Invoice -> View an invoice which has an > already-received bibliographic record. > - Go to receipt page -> Already received. > -- The "Pending orders" table is unmodified because I wasn't sure > how to use the biblio-title include in an AJAX DataTable. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 6 +++++- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt | 2 +- > 5 files changed, 10 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 56462c51d5..a932c5f25c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -486,7 +486,7 @@ > <p> > [% IF ( books_loo.order_received ) %] <span class="order-received">(received)</span>[% END %] > [% IF books_loo.title %] >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% books_loo.biblionumber | uri %]">[% books_loo.title | html %]</a>[% IF books_loo.author %] by [% books_loo.author | html %][% END %] >+ [% INCLUDE 'biblio-title.inc' biblio=books_loo link = 1 %] [% IF books_loo.author %] by [% books_loo.author | html %][% END %] > [% ELSE %] > <em>Deleted bibliographic record, can't find title</em><br /> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index 6638449a4b..4b02f1ff65 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -342,7 +342,7 @@ > <tr> > <td> > [% IF order.biblionumber %] >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% order.biblionumber | uri %]">[% order.title | html %]</a> >+ [% INCLUDE 'biblio-title.inc' biblio=order link = 1 %] > [% IF ( order.author ) %] > <br /><em>by</em> [% order.author | html %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index de7522c5af..18c0f111fd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -34,7 +34,11 @@ > > <fieldset class="rows"> > <legend>Catalog details</legend> >- <ol><li><span class="label">Title: </span><span class="title">[% order.biblio.title | html %]</span></li> >+ <ol> >+ <li> >+ <span class="label">Title: </span> >+ [% INCLUDE 'biblio-title.inc' biblio=order.biblio link = 1 %] >+ </li> > <li> <span class="label">Author: </span> > [% order.biblio.author | html %]</li> > <li><span class="label">Copyright: </span> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 44ecee72ea..d0d8a2bbe3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -213,7 +213,8 @@ > 0 > [% END %] > </td> >- <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% order.biblionumber | uri %]">[% order.title | html %]</a> >+ <td> >+ [% INCLUDE 'biblio-title.inc' biblio=order link = 1 %] > [% IF ( order.author ) %] / [% order.author | html %][% END %] > [% IF ( order.isbn ) %] - [% order.isbn | html %][% END %] > [% IF ( order.publishercode ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt >index 20f1fbe302..be9fe973e2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt >@@ -90,7 +90,7 @@ > [% uncertainpriceorder.basketname | html %] > </td> > <td> >- <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% uncertainpriceorder.biblionumber | uri %]">[% uncertainpriceorder.title | html %]</a> >+ [% INCLUDE 'biblio-title.inc' biblio=uncertainpriceorder link = 1 %] > [% IF ( uncertainpriceorder.author ) %] <em>by</em> [% uncertainpriceorder.author | html %][% END %] > [% IF ( uncertainpriceorder.publishercode ) %] > <br /><em>Publisher:</em> [% uncertainpriceorder.publishercode | html %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27817
:
118969
|
126323
|
130899
|
130900
|
130901
|
139517
|
139564
|
139679
|
140734