Attachment 119000 Details for Bug 28052 – Bug 28052 Do not check SYSENV values only keys in loop

[patch] Bug 28052 Do not check SYSENV values only keys in loop

Bug-28052-Do-not-check-SYSENV-values-only-keys-in-.patch (text/plain), 1.13 KB, created by Martin Renvoize (ashimema) on 2021-03-30 12:22:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-03-30 12:22:59 UTC

Size: 1.13 KB

patch

obsolete

>From 196c44acc97a344bc31a4c2728c8893e2c831ae2 Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Tue, 30 Mar 2021 12:13:27 +0100
>Subject: [PATCH] Bug 28052 Do not check SYSENV values only keys in loop
>
>Loop is only interested in key values, because 'keys' is omitted
>it is checking values as well. This can lead to misleading errors
>being logged (e.g. key is undefined)
>Extract keys only to loop array as in the other loops below this
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/SIP/Sip/MsgType.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/SIP/Sip/MsgType.pm b/C4/SIP/Sip/MsgType.pm
>index 62d3d5fcfc..1e38f29a68 100644
>--- a/C4/SIP/Sip/MsgType.pm
>+++ b/C4/SIP/Sip/MsgType.pm
>@@ -333,7 +333,7 @@ sub handle {
> 
>     # Set system preference overrides, first global, then account level
>     # Clear overrides from previous message handling first
>-    foreach my $key ( %ENV ) {
>+    foreach my $key ( keys %ENV ) {
>         delete $ENV{$key} if index($key, 'OVERRIDE_SYSPREF_') > 0;
>     }
>     foreach my $key ( keys %{ $config->{'syspref_overrides'} } ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28052: 118990 | 119000 | 119010