Attachment 119027 Details for Bug 26459 – Bug 26459: (follow-up) Clarify language and remove duplicated code

[patch] Bug 26459: (follow-up) Clarify language and remove duplicated code

Bug-26459-follow-up-Clarify-language-and-remove-du.patch (text/plain), 1.37 KB, created by Victor Grousset/tuxayo on 2021-03-30 22:29:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2021-03-30 22:29:45 UTC

Size: 1.37 KB

patch

obsolete

>From 4498c9cf3dec4401a994976356bd9316f00c8dab Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 29 Mar 2021 18:51:59 +0000
>Subject: [PATCH] Bug 26459: (follow-up) Clarify language and remove duplicated
> code
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> misc/sip_cli_emulator.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/misc/sip_cli_emulator.pl b/misc/sip_cli_emulator.pl
>index 657847fd59..3044b044b4 100755
>--- a/misc/sip_cli_emulator.pl
>+++ b/misc/sip_cli_emulator.pl
>@@ -494,7 +494,7 @@ sub build_checkin_command_message {
> sub build_hold_command_message {
>     my ($params) = @_;
> 
>-    my $hold_mode         = $params->{hold_mode} || '+';
>+    my $hold_mode         = $params->{hold_mode};
>     my $transaction_date  = $params->{transaction_date};
>     my $expiration_date   = $params->{expiration_date};
>     my $pickup_location   = $params->{pickup_location};
>@@ -641,7 +641,7 @@ Options:
>   --fee-identifier  Fee identifier for Fee Paid message, optional
>   --transaction-id  Transaction id for Fee Paid message, optional
>   --pickup-location Pickup location (branchcode) for Hold message, optional
>-  --hold-mode       Accepts +: Add hold or -:cancel hold, defaults to +
>+  --hold-mode       Accepts "+" to add hold or "-" to cancel hold, defaults to +
> 
>   -m --message     SIP2 message to execute
> 
>-- 
>2.31.0

Actions: View | Diff | Splinter Review

Attachments on bug 26459: 110071 | 113066 | 118980 | 119026 | 119027