Bugzilla – Attachment 119125 Details for
Bug 28013
Improvements to CanBookBeRenewed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28013: (follow-up) Correct and update call to CanItemBeReserved
Bug-28013-follow-up-Correct-and-update-call-to-Can.patch (text/plain), 1.18 KB, created by
Nick Clemens (kidclamp)
on 2021-04-02 14:36:37 UTC
(
hide
)
Description:
Bug 28013: (follow-up) Correct and update call to CanItemBeReserved
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-04-02 14:36:37 UTC
Size:
1.18 KB
patch
obsolete
>From 9c9db41f68289d476aadde30bdf8b891679b70ab Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 2 Apr 2021 14:32:33 +0000 >Subject: [PATCH] Bug 28013: (follow-up) Correct and update call to > CanItemBeReserved > >The current call checks for truth against a returned hash, we need >to check the 'status' value >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 0c9c271854..39848cb21e 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2917,7 +2917,7 @@ sub CanBookBeRenewed { > next if IsItemOnHoldAndFound( $item->itemnumber ); > while ( my $patron = $patrons->next ) { > next unless IsAvailableForItemLevelRequest($item, $patron); >- next unless CanItemBeReserved($patron->borrowernumber,$item->itemnumber); >+ next unless CanItemBeReserved($patron->borrowernumber,$item->itemnumber,undef,{ignore_hold_counts=>1})->{status} eq 'OK'; > push @reservable, $item->itemnumber; > if (@reservable >= @borrowernumbers) { > $resfound = 0; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28013
:
118592
|
118928
|
118950
|
118951
|
119125
|
119126
|
119127
|
119253
|
119257
|
119258
|
119259
|
119260
|
119261