Bugzilla – Attachment 119130 Details for
Bug 23243
Allow filtering out of historic subscription expirations in the check expiration of serials page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23243: Adjust previous patch
Bug-23243-Adjust-previous-patch.patch (text/plain), 2.73 KB, created by
Séverine Queune
on 2021-04-02 15:20:45 UTC
(
hide
)
Description:
Bug 23243: Adjust previous patch
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2021-04-02 15:20:45 UTC
Size:
2.73 KB
patch
obsolete
>From e1aadded50a39eb668d09254300a82fbc9db90c6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 12 Dec 2019 11:07:31 +0100 >Subject: [PATCH] Bug 23243: Adjust previous patch >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt | 7 +++++-- > serials/checkexpiration.pl | 4 ++-- > 2 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >index 196516d02f..019d415fe6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt >@@ -61,8 +61,11 @@ > > <li> > <label for="showhistoricexpired">Include historic expirations:</label> >- <input id="showhistoricexpired" type="checkbox" name="showhistoricexpired" >- [% IF ( showhistoricexpired ) %] checked="checked" [% END %]/> >+ [% IF showhistoricexpired %] >+ <input id="showhistoricexpired" type="checkbox" name="showhistoricexpired" checked="checked" /> >+ [% ELSE %] >+ <input id="showhistoricexpired" type="checkbox" name="showhistoricexpired" /> >+ [% END %] > </li> > </ol> > </fieldset> >diff --git a/serials/checkexpiration.pl b/serials/checkexpiration.pl >index 2b6f202134..aeebd2f5bc 100755 >--- a/serials/checkexpiration.pl >+++ b/serials/checkexpiration.pl >@@ -69,7 +69,7 @@ my $issn = $query->param('issn'); > my $branch = $query->param('branch'); > my $date = $query->param('date'); > $date = eval { dt_from_string( scalar $query->param('date') ) } if $date; >-my $showhistoricexpired = $query->param('showhistoryexpired'); >+my $showhistoricexpired = $query->param('showhistoricexpired'); > > if ($date) { > my @subscriptions = SearchSubscriptions({ title => $title, issn => $issn, orderby => 'title' }); >@@ -96,7 +96,7 @@ if ($date) { > my $expirationdate_dt = dt_from_string( $expirationdate, 'iso' ); > my $today_dt = dt_from_string(); > if ( DateTime->compare( $date, $expirationdate_dt ) == 1 >- && ( $showhistoricexpired || DateTime->compare( $expiration_dt, $today_dt ) == 1 ) >+ && ( $showhistoricexpired || DateTime->compare( $expirationdate_dt, $today_dt ) == 1 ) > && ( !$branch || ( $subscription->{'branchcode'} eq $branch ) ) ) { > push @subscriptions_loop, $subscription; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23243
:
91138
|
96215
|
105491
|
105492
|
105493
|
119129
|
119130
|
119131
|
119826
|
119827
|
119828