Attachment 119156 Details for Bug 27805 – Bug 27805: (follow-up) Update more instances

[patch] Bug 27805: (follow-up) Update more instances

Bug-27805-follow-up-Update-more-instances.patch (text/plain), 3.52 KB, created by Katrin Fischer on 2021-04-03 14:14:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-04-03 14:14:24 UTC

Size: 3.52 KB

patch

obsolete

>From dad4f6e134e4c1a65c5d8a5f04b73f56270b319e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 29 Mar 2021 11:57:48 +0000
>Subject: [PATCH] Bug 27805: (follow-up) Update more instances
>
>This patch updates some preferences I missed in the first round:
>
>- NoticeBcc
>- ILLDefaultStaffEmail
>- PayPalUser
>- EmailSMSSendDriverFromAddress
>
>I've also modified the preferences CSS so that fields with type "email"
>are styled the same as fields with the "long" class to give more room
>for email addresses.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/css/preferences.css                       | 3 ++-
> .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref   | 2 ++
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref    | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref | 1 +
> 4 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/preferences.css b/koha-tmpl/intranet-tmpl/prog/css/preferences.css
>index 2745deda46..60114036c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/preferences.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/preferences.css
>@@ -1,3 +1,4 @@
>+.preference-email,
> .preference-url,
> .preference-multi,
> .preference-long,
>@@ -6,7 +7,7 @@
>     width: 20em;
> }
> 
>-.preference-short, .preference-email {
>+.preference-short {
>     width: 10em;
> }
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 157bbea997..7d4b42fcc4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -393,6 +393,7 @@ Circulation:
>         -
>             - "Send all notices as a BCC to this email address:"
>             - pref: NoticeBcc
>+              class: email
>         -
>             - pref: OverdueNoticeCalendar
>               choices:
>@@ -947,6 +948,7 @@ Circulation:
>         -
>             - "Fallback email address for staff ILL notices to be sent to in the absence of a library address:"
>             - pref: ILLDefaultStaffEmail
>+              class: email
>     Fines Policy:
>         -
>             - pref: finesCalendar
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 67ef50a828..c7f0bd8111 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -907,7 +907,7 @@ OPAC:
>         -
>             - "The email address to receive PayPal payments is "
>             - pref: PayPalUser
>-              class: long
>+              class: email
>             - "."
>         -
>             - "The password for the PayPal account to receive payments is "
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>index e599773fa2..ef3f6550ba 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>@@ -184,6 +184,7 @@ Patrons:
>          - pref: SMSSendPassword
>          - ". Override from address with"
>          - pref: EmailSMSSendDriverFromAddress
>+           class: email
>          - "for emails sent using \"Email\" send driver."
>      -
>          - pref: FallbackToSMSIfNoEmail
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27805: 117733 | 118712 | 118952 | 119155 | 119156