Attachment 119158 Details for Bug 28037 – Bug 28037: Improve breadcrumbs of CSV profiles page

[patch] Bug 28037: Improve breadcrumbs of CSV profiles page

Bug-28037-Improve-breadcrumbs-of-CSV-profiles-page.patch (text/plain), 2.76 KB, created by Katrin Fischer on 2021-04-03 14:53:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2021-04-03 14:53:35 UTC

Size: 2.76 KB

patch

obsolete

>From a9370106b8c682631ea9d58029955e2badb1f74f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 25 Mar 2021 18:20:39 +0000
>Subject: [PATCH] Bug 28037: Improve breadcrumbs of CSV profiles page
>
>This patch expands the logic around the page title and breadcrumbs of
>the CSV profiles page.
>
>The name of the page has also been changed from "CSV export profiles" to
>"CSV profiles" to match links elsewhere in Koha.
>
>To test, apply the patch and go to Tools -> CSV profiles.
>
>- The initial state of the page title and breadcrumbs menu should be
>  "Tools > CSV profiles."
>- Click "New CSV profile." The page title and breadcrumbs should show
>  "Tools > CSV profiles > New CSV profile."
>- Edit an existing CSV profile. The page title and breadcrumbs should
>  show "Tools > CSV profiles > Modify a CSV profile."
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/tools/csv-profiles.tt          | 38 ++++++++++++++++++----
> 1 file changed, 32 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt
>index 6035395683..fbd0e616a7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/csv-profiles.tt
>@@ -2,7 +2,16 @@
> [% USE Asset %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>Koha &rsaquo; Tools &rsaquo; CSV export profiles</title>
>+<title>
>+    Koha &rsaquo; Tools &rsaquo; CSV profiles
>+    [% IF op == 'add_form' %]
>+        [% IF csv_profile %]
>+            &rsaquo; Modify a CSV profile
>+        [% ELSE %]
>+            &rsaquo; New CSV profile
>+        [% END %]
>+    [% END %]
>+</title>
> [% INCLUDE 'doc-head-close.inc' %]
> </head>
> 
>@@ -18,11 +27,28 @@
>         <li>
>             <a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a>
>         </li>
>-        <li>
>-            <a href="#" aria-current="page">
>-                CSV export profiles
>-            </a>
>-        </li>
>+        [% IF op == 'add_form' %]
>+            <li>
>+                <a href="/cgi-bin/koha/tools/csv-profiles.pl">
>+                    CSV profiles
>+                </a>
>+            </li>
>+            [% IF csv_profile %]
>+                <li>
>+                    <a href="#" aria-current="page">Modify a CSV profile</a>
>+                </li>
>+            [% ELSE %]
>+                <li>
>+                    <a href="#" aria-current="page">New CSV profile</a>
>+                </li>
>+            [% END %]
>+        [% ELSE %]
>+            <li>
>+                <a href="#" aria-current="page">
>+                    CSV profiles
>+                </a>
>+            </li>
>+        [% END %]
>     </ol>
> </nav>
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28037: 118836 | 118948 | 119158