Bugzilla – Attachment 119208 Details for
Bug 28017
Allow non-FQDN and IP addresses in emails
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28017: (follow-up) Fix Letters.t
Bug-28017-follow-up-Fix-Letterst.patch (text/plain), 1.95 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-04-06 11:18:17 UTC
(
hide
)
Description:
Bug 28017: (follow-up) Fix Letters.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-04-06 11:18:17 UTC
Size:
1.95 KB
patch
obsolete
>From 11d5194ac04f87d91decc7acd940494792db4956 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 6 Apr 2021 08:16:37 -0300 >Subject: [PATCH] Bug 28017: (follow-up) Fix Letters.t > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Letters.t | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index 3ba3361d281..35eb84d32ed 100755 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -962,7 +962,7 @@ subtest 'Test limit parameter for SendQueuedMessages' => sub { > > subtest 'Test message_id parameter for SendQueuedMessages' => sub { > >- plan tests => 5; >+ plan tests => 6; > > my $dbh = C4::Context->dbh; > >@@ -987,7 +987,7 @@ subtest 'Test message_id parameter for SendQueuedMessages' => sub { > 'borrowernumber' => $borrowernumber, > 'to_address' => 'to@example.org', > 'message_transport_type' => 'email', >- 'from_address' => 'root@localhost' # invalid KohaAdminEmailAddress >+ 'from_address' => 'root@localhost.' # invalid KohaAdminEmailAddress > }; > my $message_id = C4::Letters::EnqueueLetter($my_message); > throws_ok { >@@ -1000,7 +1000,9 @@ subtest 'Test message_id parameter for SendQueuedMessages' => sub { > > $my_message->{from_address} = 'root@example.org'; # valid KohaAdminEmailAddress > $message_id = C4::Letters::EnqueueLetter($my_message); >- C4::Letters::SendQueuedMessages( { message_id => $message_id } ); >+ warning_like { C4::Letters::SendQueuedMessages( { message_id => $message_id } ); } >+ qr|Fake send_or_die|, >+ "SendQueuedMessages is using the mocked send_or_die routine"; > $message_1 = C4::Letters::GetMessage($message_1->{message_id}); > my $message_2 = C4::Letters::GetMessage($message_id); > is( $message_1->{status}, 'pending', 'Message 1 status is unchanged' ); # Must be 'failed' >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28017
:
118620
|
118621
|
118622
|
118644
|
118645
|
118646
|
118668
|
118696
|
118697
|
118698
| 119208