Attachment 119212 Details for Bug 28092 – Bug 28092: Add reserve notes column to holds to pull

[patch] Bug 28092: Add reserve notes column to holds to pull

Bug-28092-Add-reserve-notes-column-to-holds-to-pul.patch (text/plain), 2.51 KB, created by Peter Vashchuk on 2021-04-06 12:53:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Vashchuk

Created: 2021-04-06 12:53:01 UTC

Size: 2.51 KB

patch

obsolete

>From 8722e19b6a0c91797acdb9fa30321d163d2b5232 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 5 Apr 2021 22:39:43 +0000
>Subject: [PATCH] Bug 28092: Add reserve notes column to holds to pull
>
>To test:
>-PLace a hold and add a reserve note to that hold
>-Go to Circulation > Holds to pull
>-Notice there is no reserve notes column
>-Apply patch and restart all the things
>-Reload the Holds to pull report and you should see a reserve notes column
>-Go to table settings (/cgi-bin/koha/admin/columns_settings.pl) and make sure you can properly hide the column.
>-Test other columns in the table and make sure you can properly hide them
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com>
>---
> admin/columns_settings.yml                                     | 2 ++
> .../intranet-tmpl/prog/en/modules/circ/pendingreserves.tt      | 3 +++
> 2 files changed, 5 insertions(+)
>
>diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
>index 0a14a84508..df9290d727 100644
>--- a/admin/columns_settings.yml
>+++ b/admin/columns_settings.yml
>@@ -1195,6 +1195,8 @@ modules:
>               columnname: locations
>             -
>               columnname: hold_date
>+            -
>+              columnname: reserve_notes
>             -
>               columnname: action
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>index a06981896d..7207f4b240 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt
>@@ -64,6 +64,7 @@
>         <th class="string-sort">Available item types</th>
>         <th class="string-sort">Available locations</th>
>         <th class="title-string">Earliest hold date</th>
>+        <th>Reserve notes</th>
>         <th>Action</th>
>         </tr>
>     </thead>
>@@ -163,6 +164,7 @@
>         <td>
>             <span title="[% hold.reservedate | html %]">[% hold.reservedate | $KohaDates %] in [% Branches.GetName ( hold.branchcode ) | html %]</span>
>         </td>
>+        <td>[% hold.reservenotes | html %]</td>
>         <td>
>             <form name="cancelReserve" action="/cgi-bin/koha/circ/pendingreserves.pl" method="post">
>                 <input type="hidden" name="op" value="cancel_reserve" />
>@@ -224,6 +226,7 @@
>         <td id="locationfilter"></td>
>         <td></td>
>         <td></td>
>+        <td></td>
>         </tr>
>     </tfoot>
>     </table>
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 28092: 119190 | 119210 | 119212 | 119216