Attachment 119217 Details for Bug 21958 – Bug 21958: Allow 'e' subfield for authorities

[patch] Bug 21958: Allow 'e' subfield for authorities

Bug-21958-Allow-e-subfield-for-authorities.patch (text/plain), 1.37 KB, created by Nick Clemens (kidclamp) on 2021-04-06 12:58:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-04-06 12:58:56 UTC

Size: 1.37 KB

patch

obsolete

>From db405640811f88c5b174c7390766f74b35df5ce9 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 6 Apr 2021 12:56:50 +0000
>Subject: [PATCH] Bug 21958: Allow 'e' subfield for authorities
>
>This bug specifically changed the code to allow for e in authority record
>
>This is a tricky issue, see link for discussion:
>https://www.loc.gov/marc/marbi/2008/2008-dp05-1.html
>
>It seems to be allowed, but possibly not useful?
>
>In either case I think for now we can allow in the test to fix this error
>and possibly open a new bug for further discussion
>---
> t/db_dependent/Heading.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Heading.t b/t/db_dependent/Heading.t
>index e2f7064667..1615ea0eaa 100755
>--- a/t/db_dependent/Heading.t
>+++ b/t/db_dependent/Heading.t
>@@ -35,7 +35,7 @@ subtest "MARC21 tests" => sub {
>     ok(!C4::Heading::valid_heading_subfield('100', 'e'), '100e not valid for bib');
> 
>     ok(C4::Heading::valid_heading_subfield('100', 'a', 1), '100a valid for authority');
>-    ok(!C4::Heading::valid_heading_subfield('100', 'e', 1), '100e not valid for authority');
>+    ok(C4::Heading::valid_heading_subfield('100', 'e', 1), '100e valid for authority');
> 
>     ok(C4::Heading::valid_heading_subfield('110', 'a'), '110a valid for bib');
>     ok(!C4::Heading::valid_heading_subfield('110', 'e'), '110e not valid for bib');
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21958: 84283 | 91150 | 92611 | 99528 | 108182 | 114303 | 118795 | 118796 | 119217