Bugzilla – Attachment 11923 Details for
Bug 8702
System preferences search does not allow accented letters
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch (revised)
Bug-8702-System-preferences-search-does-not-allow-ac.patch (text/plain), 3.48 KB, created by
Fridolin Somers
on 2012-08-31 16:04:28 UTC
(
hide
)
Description:
Proposed patch (revised)
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2012-08-31 16:04:28 UTC
Size:
3.48 KB
patch
obsolete
>From d3eecd8ca1dfcd72bbed39088f98f7bd43d9e18c Mon Sep 17 00:00:00 2001 >From: Fridolyn SOMERS <fridolyn.somers@biblibre.com> >Date: Wed, 29 Aug 2012 16:50:18 +0200 >Subject: [PATCH] Bug 8702: System preferences search does not allow accented > letters > >--- > admin/preferences.pl | 5 ++++- > .../prog/en/includes/prefs-admin-search.inc | 2 +- > .../prog/en/includes/sysprefs-admin-search.inc | 2 +- > .../prog/en/modules/admin/preferences.tt | 2 +- > 4 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/admin/preferences.pl b/admin/preferences.pl >index b1ad005..db91e76 100755 >--- a/admin/preferences.pl >+++ b/admin/preferences.pl >@@ -297,7 +297,10 @@ my @TABS; > if ( $op eq 'search' ) { > my $searchfield = $input->param( 'searchfield' ); > >- $searchfield =~ s/[^a-zA-Z0-9_ -]//g; >+ $searchfield =~ s/\p{IsC}//g; >+ $searchfield =~ s/\s+/ /; >+ $searchfield =~ s/^\s+//; >+ $searchfield =~ s/\s+$//; > > $template->param( searchfield => $searchfield ); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc >index ad13bec..06b0752 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc >@@ -6,7 +6,7 @@ > <form action="/cgi-bin/koha/admin/preferences.pl"> > <input type="hidden" name="tab" value="[% last_tab %]" /> > <input type="hidden" name="op" value="search" /> >- <input type="text" size="40" name="searchfield" value="[% searchfield %]" /> >+ <input type="text" size="40" name="searchfield" value="[% searchfield |html %]" /> > <input type="submit" class="submit" value="Search" /> > </form> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc >index fa9fc4b..aa654c4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc >@@ -4,7 +4,7 @@ > <div id="syspref_search" class="residentsearch"> > <p class="tip">System preference search:</p> > <form action="/cgi-bin/koha/admin/preferences.pl" method="post"> >- <input type="text" size="40" name="searchfield" value="[% searchfield %]" /> >+ <input type="text" size="40" name="searchfield" value="[% searchfield |html %]" /> > <input type="hidden" value="all" name="tab" /> > <input type="submit" name="ok" class="submit" value="Search" /> > </form> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index 875b863..9591003 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -42,7 +42,7 @@ > [% END %] > [% IF ( search_not_found ) %] > <div class="dialog alert"> >- No system preferences matched your search for <strong>[% searchfield %]</strong>. You can try a different search or <a href="/cgi-bin/koha/admin/preferences.pl?tab=[% last_tab %]">return to where you were before.</a> >+ No system preferences matched your search for <strong>[% searchfield |html %]</strong>. You can try a different search or <a href="/cgi-bin/koha/admin/preferences.pl?tab=[% last_tab %]">return to where you were before.</a> > </div> > [% END %] > [% FOREACH TAB IN TABS %] >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8702
:
11879
|
11923
|
12311
|
12324