Attachment 119371 Details for Bug 27883 – Bug 27883: (follow-up) Make label match input id

[patch] Bug 27883: (follow-up) Make label match input id

Bug-27883-follow-up-Make-label-match-input-id.patch (text/plain), 1.92 KB, created by Kyle M Hall (khall) on 2021-04-09 11:22:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-04-09 11:22:57 UTC

Size: 1.92 KB

patch

obsolete

>From 111e5de09bc0cc709c4ba2aea7cedd70115d8b51 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 30 Mar 2021 15:04:24 +0000
>Subject: [PATCH] Bug 27883: (follow-up) Make label match input id
>
>This change alters the list of columns under "Preserve existing values,"
>changing the label for each checkbox can be clicked to trigger the
>checkbox change.
>
>To test, apply the patch and refresh the patron import page. Expand the
>"Preserve existing values" section and click any label in the list. The
>corresponding checkbox should be checked.
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../intranet-tmpl/prog/en/modules/tools/import_borrowers.tt     | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
>index 3622db36b4..83b6f82b59 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
>@@ -269,7 +269,7 @@
>                 <div class="hint">Selected fields will be preserved from original patron record when overwriting existing patron.</div>
>                 [% FOREACH borrower_field IN borrower_fields %]
>                         <li>
>-                            <label class="description" for="[% borrower_field.field | html %]">[% borrower_field.description | html %]: </label>
>+                            <label class="description" for="preserve_existing_[% borrower_field.field | html %]">[% borrower_field.description | html %]: </label>
>                             <input name="preserve_existing" id="preserve_existing_[%  borrower_field.field | html %]" value="[%  borrower_field.field | html %]" type="checkbox">
>                             <span class="field_hint">[% borrower_field.field | html %]</span>
>                         </li>
>-- 
>2.24.3 (Apple Git-128)

Actions: View | Diff | Splinter Review

Attachments on bug 27883: 117861 | 119018 | 119227 | 119228 | 119229 | 119230 | 119231 | 119366 | 119367 | 119370 | 119371 | 119436 | 119437 | 121883 | 121884 | 122719 | 122720