Attachment 119424 Details for Bug 24695 – Bug 24695: (QA follow-up) Fix POD

[patch] Bug 24695: (QA follow-up) Fix POD

Bug-24695-QA-follow-up-Fix-POD.patch (text/plain), 1.09 KB, created by Kyle M Hall (khall) on 2021-04-09 16:44:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2021-04-09 16:44:19 UTC

Size: 1.09 KB

patch

obsolete

>From a7589b540f9f0cb6f9c5f672113557c35bfd75b4 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 9 Apr 2021 12:41:04 -0400
>Subject: [PATCH] Bug 24695: (QA follow-up) Fix POD
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Report.pm | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/Koha/Report.pm b/Koha/Report.pm
>index c341ed60ab..1e6510219d 100644
>--- a/Koha/Report.pm
>+++ b/Koha/Report.pm
>@@ -25,6 +25,10 @@ use Koha::Reports;
> use Koha::DateUtils qw( dt_from_string output_pref );
> 
> use base qw(Koha::Object);
>+#
>+# FIXME We could only return an error code instead of the arrayref
>+# Only 1 error is returned
>+# TODO Koha::Report->store should check this before saving
> 
> =head1 NAME
> 
>@@ -34,11 +38,6 @@ Koha::Report - Koha Report Object class
> 
> =head2 Class Methods
> 
>-=cut
>-
>-# FIXME We could only return an error code instead of the arrayref
>-# Only 1 error is returned
>-# TODO Koha::Report->store should check this before saving
> =head3 is_sql_valid
> 
> my ( $is_sql_valid, $errors ) = $report->is_sql_valid;
>-- 
>2.24.3 (Apple Git-128)

Actions: View | Diff | Splinter Review

Attachments on bug 24695: 99305 | 99625 | 99694 | 117352 | 117353 | 119421 | 119422 | 119423 | 119424