Attachment 119510 Details for Bug 14233 – Bug 14233: Set default for NoticesLog to 0

[patch] Bug 14233: Set default for NoticesLog to 0

Bug-14233-Set-default-for-NoticesLog-to-0.patch (text/plain), 2.20 KB, created by Jonathan Druart on 2021-04-13 08:46:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-04-13 08:46:36 UTC

Size: 2.20 KB

patch

obsolete

>From 587a838b338364b330b803274e3b24f2c2107946 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 13 Apr 2021 10:45:58 +0200
>Subject: [PATCH] Bug 14233: Set default for NoticesLog to 0
>
>To prevent a warning on the about page:
> System preference 'NoticesLog' must be '0' or '1', but is ''.
>---
> installer/data/mysql/mandatory/sysprefs.sql | 2 +-
> installer/data/mysql/updatedatabase.pl      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index b06c51e9cde..e0f803a98c7 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -356,7 +356,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('NotHighlightedWords','and|or|not',NULL,'List of words to NOT highlight when OpacHitHighlight is enabled','free'),
> ('NoticeBcc','','','Email address to bcc outgoing notices sent by email','free'),
> ('NoticeCSS','',NULL,'Notices CSS url.','free'),
>-('NoticesLog','',NULL,'If enabled, log changes to notice templates','YesNo'),
>+('NoticesLog','0',NULL,'If enabled, log changes to notice templates','YesNo'),
> ('NotifyBorrowerDeparture','30',NULL,'Define number of days before expiry where circulation is warned about patron account expiry','Integer'),
> ('NovelistSelectEnabled','0',NULL,'Enable Novelist Select content.  Requires Novelist Profile and Password','YesNo'),
> ('NovelistSelectPassword','',NULL,'Novelist select user Password','free'),
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 0c9498132e5..582056114a8 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -23784,7 +23784,7 @@ if ( CheckVersion($DBversion) ) {
> 
>     $dbh->do(q{
>         INSERT IGNORE INTO systempreferences (variable, value, explanation, options, type)
>-        VALUES ('NoticesLog','',NULL,'If enabled, log changes to notice templates','YesNo')
>+        VALUES ('NoticesLog','0',NULL,'If enabled, log changes to notice templates','YesNo')
>     });
> 
>     NewVersion( $DBversion, 14233, "Add id field to letter table" );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 14233: 116649 | 116650 | 116651 | 116660 | 116661 | 116662 | 116668 | 116671 | 116672 | 116673 | 116674 | 116713 | 116760 | 116761 | 117251 | 117252 | 117253 | 117254 | 117255 | 117256 | 117257 | 117258 | 117259 | 117294 | 117295 | 117296 | 117297 | 117298 | 117299 | 117300 | 117301 | 117302 | 117303 | 117304 | 117311 | 117312 | 117313 | 117314 | 117315 | 117316 | 117317 | 117318 | 117319 | 117320 | 117321 | 117345 | 118132 | 118133 | 118134 | 118135 | 118136 | 118137 | 118138 | 118139 | 118140 | 118141 | 118142 | 118143 | 118155 | 118156 | 118157 | 118158 | 118159 | 118160 | 118161 | 118162 | 118163 | 118164 | 118165 | 118166 | 118167 | 118323 | 119291 | 119292 | 119293 | 119294 | 119312 | 119313 | 119314 | 119315 | 119359 | 119360 | 119361 | 119362 | 119510