Bugzilla – Attachment 119544 Details for
Bug 27631
Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27631: reports and serials folders
Bug-27631-reports-and-serials-folders.patch (text/plain), 14.25 KB, created by
Wainui Witika-Park
on 2021-04-13 22:35:50 UTC
(
hide
)
Description:
Bug 27631: reports and serials folders
Filename:
MIME Type:
Creator:
Wainui Witika-Park
Created:
2021-04-13 22:35:50 UTC
Size:
14.25 KB
patch
obsolete
>From 14a95c33c79b9891fb276b26d5675155c43dbfa8 Mon Sep 17 00:00:00 2001 >From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> >Date: Mon, 5 Apr 2021 09:34:34 +0000 >Subject: [PATCH] Bug 27631: reports and serials folders > >Changed each of the pages in the reports and serials folders to >have one <h1> tag showing that describes the page, rather than the <h1> >describing the logo. > >The hierarchy of heading tags may be broken in many pages, but this will >be dealt with in an additional bug. > >To test: >1) Go to the Staff Client >2) Apply patch >3) Go to each of the pages in the reports and serials folders and >check that they have an obvious and descriptive heading >4) Ensure that the heading in the page is <h1> > >Sponsored-by: Catalyst IT >--- > .../intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt | 1 + > .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 6 ++++-- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 5 +++-- > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt | 2 ++ > koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt | 2 +- > .../intranet-tmpl/prog/en/modules/serials/subscription-renew.tt | 2 ++ > 17 files changed, 25 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >index 4db99d2c41..b410700b92 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >@@ -15,9 +15,9 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >+<h1>Acquisitions statistics </h1> > [% IF ( do_it ) %] > [% FOREACH mainloo IN mainloop %] >- <h1>Acquisitions statistics </h1> > [% IF ( mainloo.loopfilter.size ) %] > <p><strong>Filtered on:</strong></p> > [% FOREACH loopfilte IN mainloo.loopfilter %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >index 17a0ee21b0..461cf594e1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/borrowers_stats.tt >@@ -21,9 +21,9 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >+<h1>Patrons statistics</h1> > [% IF ( do_it ) %] > [% FOREACH mainloo IN mainloop %] >- <h1>Patrons statistics</h1> > [% IF ( mainloo.loopfilter.size>0 ) %] > <p>Filtered on:</p> > [% FOREACH loopfilte IN mainloo.loopfilter %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >index 17f6b400bf..150aac4b10 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >@@ -16,9 +16,9 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >+<h1>Catalog statistics</h1> > [% IF ( do_it ) %] > [% FOREACH mainloo IN mainloop %] >- <h1>Catalog statistics</h1> > [% IF ( mainloo.loopfilter ) %] > <p>Filtered on:</p> > [% FOREACH loopfilte IN mainloo.loopfilter %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt >index f8395d3399..ae9889fece 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/convert_report.tt >@@ -3,6 +3,7 @@ > <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> > </head> > <body id="rep_report_convert" class="rep"> >+ <h1>Convert report</h1> > <div> > [% IF msg == 'no_report' %] > There is no valid report for this id. >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index c2c3138d94..4f6eec45c7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -125,7 +125,7 @@ > [% INCLUDE "reports-toolbar.inc" %] > > [% IF ( start ) %] >- <h2>Guided reports</h2> >+ <h1>Guided reports</h1> > <p>Use the guided reports engine to create non standard reports. This feature aims to provide some middle ground between the built in canned reports and writing custom SQL reports.</p> > > <h3>Build and run reports</h3> >@@ -172,8 +172,8 @@ > [% END %] > > [% IF ( saved1 ) %] >- [% IF ( savedreports ) %] > <h1>Saved reports</h1> >+ [% IF ( savedreports ) %] > > [% IF ( filters.date || filters.author || filters.keyword ) %] > <p>Filtered by: >@@ -1058,6 +1058,7 @@ > [% END #/IF ( execute ) %] > > [% IF ( create ) %] >+ <h1>Create from SQL</h1> > <form action="/cgi-bin/koha/reports/guided_reports.pl" method="post" id="sql_report_form"> > <fieldset class="rows"> > <legend>Create report from SQL</legend> >@@ -1142,6 +1143,7 @@ > [% END # /IF saved_results %] > > [% IF ( showsql ) %] >+ <h1>Saved reports - SQL</h1> > <fieldset class="rows"> > <legend>[% reportname | html %]</legend> > <ol> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >index 6a61633de9..7759d027bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt >@@ -16,9 +16,9 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >+<h1>Average checkout period</h1> > [% IF ( do_it ) %] > [% FOREACH mainloo IN mainloop %] >- <h1>Average checkout period</h1> > [% IF ( mainloo.loopfilter ) %] > <p>Filtered on:</p> > [% FOREACH loopfilte IN mainloo.loopfilter %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index c39a606683..a5af8a048e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -19,9 +19,9 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >+<h1>Circulation statistics</h1> > [% IF ( do_it ) %] > [% FOREACH mainloo IN mainloop %] >- <h1>Circulation statistics</h1> > [% IF ( mainloo.loopfilter ) %] > <p>Filtered on:</p> > <ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt >index 89f256708b..d3d4885a9b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemtypes.tt >@@ -49,7 +49,7 @@ > </table> > [% END %] > [% ELSE %] >- <h3>View a count of items held at your library grouped by item type</h3> >+ <h1>View a count of items held at your library grouped by item type</h1> > <form method="post" action="/cgi-bin/koha/reports/manager.pl?report_name=itemtypes"> > <fieldset class="rows"> > <ol> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >index e7edc4ee5f..4058bcc81f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt >@@ -13,7 +13,7 @@ > <div class="main container-fluid"> > <div class="row"> > <div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2"> >- >+ <h1>Reports</h1> > <div class="row"> > <div class="col-xs-6"> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >index 0ee58a9ee9..d0ae51a08c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt >@@ -20,9 +20,9 @@ > <main> > > >+<h1>Holds statistics</h1> > [% IF ( do_it ) %] > [% IF ( mainloop ) %] >- <h1>Holds statistics</h1> > [% IF ( loopfilter ) %] > <p>Filtered on:</p> > <ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt >index 24afcefd25..dd23ae1aef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt >@@ -15,7 +15,7 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >-<h2>Preview routing list for <em>[% title | html %]</em></h2> >+<h1>Preview routing list for <em>[% title | html %]</em></h1> > > <form method="post" action="routing-preview.pl"> > <input type="hidden" id="subscriptionid" name="subscriptionid" value="[% subscriptionid | html %]" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt >index d1032e26d1..f5fc7cb6fe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt >@@ -21,7 +21,6 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > <main> >-[% INCLUDE 'blocking_errors.inc' %] > > [% IF ( op ) %] > <h1>Create routing list for <em>[% title | html %]</em></h1> >@@ -29,6 +28,7 @@ > <h1>Edit routing list for <em>[% title | html %]</em></h1> > [% END %] > >+[% INCLUDE 'blocking_errors.inc' %] > <form method="post" action="routing.pl"> > <input type="hidden" name="op" value="save" /> > <input type="hidden" name="subscriptionid" value="[% subscriptionid | html %]" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >index 989029eeb3..bf0a2735b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt >@@ -90,11 +90,12 @@ $(document).ready(function() { > <div class="col-sm-10 col-sm-push-2"> > <main> > >- [% INCLUDE 'modals/serials_multi_receiving.inc' %] >- > <h1>Serial edition <em>[% bibliotitle | html %]</em> > [% IF location %] ([% AuthorisedValues.GetByCode('LOC', location) | html %])[% END %] > [% IF ( callnumber ) %] callnumber: [% callnumber | html %][% END %]</h1> >+ >+ [% INCLUDE 'modals/serials_multi_receiving.inc' %] >+ > [% IF internalnotes %]<p>Nonpublic note: [% internalnotes | html | html_line_break %]</p>[% END %] > <form method="post" name="f" class="noEnterSubmit" action="serials-edit.pl" id="serials_edit"> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt >index 8b85891a2e..588a4dff16 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt >@@ -20,6 +20,8 @@ > > [% INCLUDE 'serials-toolbar.inc' %] > >+ <h1>Serials</h1> >+ > </main> > </div> <!-- /.col-sm-10.col-sm-push-2 --> > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >index 3a538e1e8e..8b8b992bbe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt >@@ -207,9 +207,9 @@ > [% INCLUDE 'serials-toolbar.inc' %] > > [% IF ( done_searched ) %] >- <h2>Serials subscriptions ([% total | html %] found)</h2> >+ <h1>Serials subscriptions ([% total | html %] found)</h1> > [% ELSE %] >- <h2>Serials subscriptions search</h2> >+ <h1>Serials subscriptions search</h1> > [% END %] > > [% UNLESS ( done_searched ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt >index c684348deb..7dbbbc901f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/showpredictionpattern.tt >@@ -1,5 +1,5 @@ > [% USE KohaDates %] >-<h2>Prediction pattern</h1> >+<h2>Prediction pattern</h2> > [% IF (not_consistent_end_date) %] > <p><em>End date is not consistent with subscription length.</em></p> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >index f3f8c16d09..b1d9714b46 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt >@@ -13,6 +13,8 @@ > <body id="ser_subscription-renew" class="ser"> > <div class="container-fluid"> > >+ <h1>Serials subscription renew</h1> >+ > [% INCLUDE 'blocking_errors.inc' %] > > [% IF op == 'renew' OR op =='multi_renew' %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27631
:
116352
|
119492
|
119493
|
119496
|
119497
|
119498
|
119500
|
119501
|
119502
|
119544
|
119545
|
119546
|
119547
|
119830
|
119831
|
119832
|
119834
|
119835
|
119836
|
119837
|
119838
|
119839
|
119840
|
119841
|
119842
|
119843
|
120158
|
120159
|
120160
|
120161
|
120162
|
120166
|
120190
|
120191
|
121356
|
121469
|
121470
|
121522
|
121559
|
125547
|
125548
|
125549
|
125550
|
125551
|
125552
|
125553
|
125554
|
125555
|
125556
|
125557
|
125558
|
125559
|
125560
|
125561
|
125562
|
125563
|
125564
|
127295
|
127296
|
127297
|
127298
|
127299
|
127300
|
127301
|
127302
|
127303
|
127304
|
127305
|
127306
|
127307
|
127308
|
127309
|
127310
|
127311
|
127312
|
127432
|
127433
|
127449
|
127456
|
131069
|
131070
|
131071
|
131072
|
131073
|
131074
|
131075
|
131076
|
131077
|
131078
|
131079
|
131080
|
131081
|
131082
|
131083
|
131084
|
131085
|
131086
|
131087
|
131192
|
132886
|
132887
|
132888
|
132889
|
132890
|
132891
|
132892
|
132893
|
132894
|
132895
|
132896
|
132897
|
132898
|
132899
|
132900
|
132901
|
132902
|
132903
|
132904
|
132905