Attachment 119566 Details for Bug 28081 – Bug 28081: Make card number a label in patron search results

[patch] Bug 28081: Make card number a label in patron search results

Bug-28081-Make-card-number-a-label-in-patron-searc.patch (text/plain), 2.67 KB, created by Jonathan Druart on 2021-04-14 12:09:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2021-04-14 12:09:51 UTC

Size: 2.67 KB

patch

obsolete

>From 79a5a61e1b602c4bab53dc0f99c84d2356f552b3 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 2 Apr 2021 19:54:30 +0000
>Subject: [PATCH] Bug 28081: Make card number a label in patron search results
>
>This patch modifies the output of the AJAX patron search results so that
>the number in the card number column is wrapped in a <label> tag which
>triggers the corresponding checkbox.
>
>To test, apply the patch and go to the Patrons module.
>
> - Perform a patron search which will return more than one result or
>   click on a letter to browse.
> - In the search results, confirm that clicking any card number triggers
>   the corresponding checkbox.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/members/tables/members_results.tt         | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>index 37eddc5dc4f..fe04778abda 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
>@@ -13,10 +13,10 @@
>             {
>                 [% IF CAN_user_borrowers_edit_borrowers || CAN_user_tools_manage_patron_lists %]
>                 "dt_borrowernumber":
>-                    "<input type='checkbox' class='selection' name='borrowernumber' value='[% data.borrowernumber | html %]' />",
>+                    "<input type='checkbox' id='check[% data.borrowernumber | html %]' class='selection' name='borrowernumber' value='[% data.borrowernumber | html %]' />",
>                 [% END %]
>                 "dt_cardnumber":
>-                    "[% data.cardnumber | html | $To %]",
>+                    "<label for='check[% data.borrowernumber | html %]'>[% data.cardnumber | html | $To %]</label>",
>                 "dt_name":
>                     "<a href=\"/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber | html %]\" class=\"patron_preview\" data-borrowernumber=\"[% data.borrowernumber | html %]\" style='white-space:nowrap'>[% INCLUDE 'patron-title.inc' borrowernumber = data.borrowernumber category_type = data.category_type firstname = data.firstname surname = data.surname othernames = data.othernames invert_name = 1 | $To %]</a><br /><div class='address'><ul>[%~ INCLUDE 'display-address-style' patron=data no_line_break=1 | $To ~%][% IF data.email %]<li>Email: <a href='mailto:[% data.email | html | $To %]'>[% data.email | html | $To %]</a></li>[% END %]</ul></div>",
>     "dt_dateofbirth":
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 28081: 119185 | 119189 | 119566