Bugzilla – Attachment 119577 Details for
Bug 28136
Transferred holds are not triggering
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28136: Handle Transferred status for ResFound
Bug-28136-Handle-Transferred-status-for-ResFound.patch (text/plain), 2.39 KB, created by
Martin Renvoize (ashimema)
on 2021-04-14 13:44:30 UTC
(
hide
)
Description:
Bug 28136: Handle Transferred status for ResFound
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-14 13:44:30 UTC
Size:
2.39 KB
patch
obsolete
>From 249d4236eff7a5d919c716efaab096d6424ce3b8 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 12 Apr 2021 14:18:20 +0000 >Subject: [PATCH] Bug 28136: Handle Transferred status for ResFound >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >bug 25690 added a new 'Transferred' status to 'ResFound', this status >needs to be handled in circ/returns.pl > >To test: >1 - Place a hold on an item at Branch B for pickup at Branch A >2 - Check in the item at Branch B - confirm hold and transfer >3 - Check in the item at Branch A - nothing happens? >4 - Apply patch >5 - Checkin in the item at Branch A - hold popup appears >6 - Clear the hold and place it again >7 - Set system preference 'HoldsAutoFill' to do >8 - Check in the item at Branch B - hold is found and confirmed >9 - Check in the item at Branch A - hold is found and confirmed > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > circ/returns.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index b58e340f85..28c0b832f3 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -417,7 +417,7 @@ if ( $messages->{'ResFound'}) { > my $patron = Koha::Patrons->find( $reserve->{borrowernumber} ); > my $holdmsgpreferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $reserve->{'borrowernumber'}, message_name => 'Hold_Filled' } ); > my $branchCheck = ( $userenv_branch eq $reserve->{branchcode} ); >- if ( $reserve->{'ResFound'} eq "Reserved" && C4::Context->preference('HoldsAutoFill') ) { >+ if ( ( $reserve->{'ResFound'} eq "Reserved" || $reserve->{'ResFound'} eq "Transferred" ) && C4::Context->preference('HoldsAutoFill') ) { > my $item = Koha::Items->find( $itemnumber ); > my $biblio = $item->biblio; > >@@ -443,7 +443,7 @@ if ( $messages->{'ResFound'}) { > $template->param( > waiting => $branchCheck ? 1 : undef, > ); >- } elsif ( $reserve->{'ResFound'} eq "Reserved" || $reserve->{'ResFound'} eq "Processing" ) { >+ } elsif ( $reserve->{'ResFound'} eq "Reserved" || $reserve->{'ResFound'} eq "Processing" || $reserve->{'ResFound'} eq "Transferred" ) { > $template->param( > intransit => $branchCheck ? undef : 1, > transfertodo => $branchCheck ? undef : 1, >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28136
:
119456
|
119508
| 119577