Attachment 119585 Details for Bug 28064 – Bug 28064: Add dotransfer field to slip print submission

[patch] Bug 28064: Add dotransfer field to slip print submission

Bug-28064-Add-dotransfer-field-to-slip-print-submi.patch (text/plain), 1.94 KB, created by Nick Clemens (kidclamp) on 2021-04-14 15:04:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2021-04-14 15:04:23 UTC

Size: 1.94 KB

patch

obsolete

>From 5ac8a67b692e05389dc9d9ffde6c188c19eb764d Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 31 Mar 2021 13:06:49 +0100
>Subject: [PATCH] Bug 28064: Add dotransfer field to slip print submission
>
>By changing the code to only do a javascript triggered submission from
>the from button we lose the original buttons name and value elements
>upon submission.
>
>This patch checks for those fields in the JS capture and triggers the
>addition of a new hidden form field to contain the dotransfer data.
>
>Test plan
>1/ Set AutomaticItemReturn system preference is set to "Don't"
>2/ Check in an item that belongs to another library, a dialog will ask
>   you if you want to transfer.
>3/ Click 'Yes, print slip'
>4/ Look at the item record and note the status is 'Available'.
>5/ Apply patch
>6/ Follow steps 2 - 4
>7/ Note the status is now 'In transit to...'
>8/ Signoff
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 6c8eab60e0..9cf7cf83b5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -1124,6 +1124,10 @@
>                 this.form.print_slip.value = 1;
>                 let barcode = document.getElementById('confirm-hold-barcode');
>                 if ( barcode ) barcode.remove();
>+                if ($(this).attr('name') == "dotransfer") {
>+                    var dotransfer = $("<input>").attr("type", "hidden").attr("name", "dotransfer").val("Yes");
>+                    $('#mainform').append(dotransfer);
>+                }
>                 this.form.submit();
>             });
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 28064: 119044 | 119045 | 119055 | 119056 | 119440 | 119441 | 119585 | 119993