Bugzilla – Attachment 119590 Details for
Bug 28139
Processing holds are not filled automatically
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28139: Handle Processing status with HoldsAutoFill pref turned on
Bug-28139-Handle-Processing-status-with-HoldsAutoF.patch (text/plain), 1.81 KB, created by
Nick Clemens (kidclamp)
on 2021-04-14 15:46:49 UTC
(
hide
)
Description:
Bug 28139: Handle Processing status with HoldsAutoFill pref turned on
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-04-14 15:46:49 UTC
Size:
1.81 KB
patch
obsolete
>From 535c5893cf709490fc72028ec4f662e54dc5a8e3 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Tue, 13 Apr 2021 11:22:16 +0300 >Subject: [PATCH] Bug 28139: Handle Processing status with HoldsAutoFill pref > turned on > >To test: > 1: Turn on HoldsAutoFill setting > 2: Place a item-level hold on item X at Branch A > 3: Make the hold to Processing state: > $ koha-mysql kohadev > > select * from reserves; # look up the reserve_id > > UPDATE reserves SET found = 'P', priority = 0 WHERE reserve_id = XXX; > 4: Check in the item X at Branch A - A pop-up asking confirmation comes > 5: Apply patch & restart plack > 6: Check in the item X again at Branch A - now the hold is confirmed automatically > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > circ/returns.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 28c0b832f3..07e28f4c47 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -417,7 +417,7 @@ if ( $messages->{'ResFound'}) { > my $patron = Koha::Patrons->find( $reserve->{borrowernumber} ); > my $holdmsgpreferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $reserve->{'borrowernumber'}, message_name => 'Hold_Filled' } ); > my $branchCheck = ( $userenv_branch eq $reserve->{branchcode} ); >- if ( ( $reserve->{'ResFound'} eq "Reserved" || $reserve->{'ResFound'} eq "Transferred" ) && C4::Context->preference('HoldsAutoFill') ) { >+ if ( ( $reserve->{'ResFound'} eq "Reserved" || $reserve->{'ResFound'} eq "Processing" || $reserve->{'ResFound'} eq "Transferred" ) && C4::Context->preference('HoldsAutoFill') ) { > my $item = Koha::Items->find( $itemnumber ); > my $biblio = $item->biblio; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28139
:
119511
|
119512
|
119586
|
119587
| 119590 |
119591