Bugzilla – Attachment 119623 Details for
Bug 16787
'Too many holds' message appears inappropriately and is missing data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16787: (follow-up) Fix check to ensure reasons are passed to template
Bug-16787-follow-up-Fix-check-to-ensure-reasons-ar.patch (text/plain), 1.12 KB, created by
Owen Leonard
on 2021-04-15 12:30:06 UTC
(
hide
)
Description:
Bug 16787: (follow-up) Fix check to ensure reasons are passed to template
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-04-15 12:30:06 UTC
Size:
1.12 KB
patch
obsolete
>From 252cfa337522d5ede4ef6b7aa973fd07a3ac208e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 15 Apr 2021 12:20:08 +0000 >Subject: [PATCH] Bug 16787: (follow-up) Fix check to ensure reasons are passed > to template > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > reserve/request.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 9e53e429e6..dfe48de714 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -305,10 +305,10 @@ foreach my $biblionumber (@biblionumbers) { > > #All is OK and we can continue > } >- elsif ( $canReserve eq 'noReservesAllowed') { >+ elsif ( $canReserve->{status} eq 'noReservesAllowed' || $canReserve->{status} eq 'notReservable' ) { > $no_reserves_allowed = 1; > } >- elsif ( $canReserve eq 'tooManyReserves' ) { >+ elsif ( $canReserve->{status} eq 'tooManyReserves' ) { > $exceeded_maxreserves = 1; > $template->param( maxreserves => $canReserve->{limit} ); > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16787
:
52652
|
68894
|
68895
|
72827
|
72828
|
72889
|
91146
|
91147
|
91148
|
91149
|
96152
|
97403
|
99949
|
99950
|
100951
|
101473
|
101474
|
101475
|
101895
|
107793
|
107794
|
107795
|
114675
|
114676
|
114677
|
119279
|
119280
|
119281
|
119335
|
119336
|
119337
|
119616
|
119617
|
119619
|
119620
|
119621
|
119622
|
119623
|
119738
|
119739
|
119740
|
119741
|
119942
|
120009