Bugzilla – Attachment 119630 Details for
Bug 28118
Fix missing "selected" attribute in "Pickup at" dropdown
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28118: Default to current branch when placing hold
Bug-28118-Default-to-current-branch-when-placing-h.patch (text/plain), 2.12 KB, created by
Tomás Cohen Arazi (tcohen)
on 2021-04-15 14:18:43 UTC
(
hide
)
Description:
Bug 28118: Default to current branch when placing hold
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2021-04-15 14:18:43 UTC
Size:
2.12 KB
patch
obsolete
>From b6e729dd07df1b0859c1ad9e7b8b9c4ecba325f0 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 12 Apr 2021 16:01:03 -0300 >Subject: [PATCH] Bug 28118: Default to current branch when placing hold > >During bug 27071 development, this line got inadvertedly changed. This >patch restores the original behaviour. > >To test: >1. Search for a title >2. Go try place a hold >=> FAIL: Look at the HTML, there's no pickup location with >selected="selected" >3. Switch branch and repeat 2 >=> FAIL: Still the same >4. Apply this patch >5. Repeat 2 and 3 >=> SUCCESS: Branch is selected, chosen current branch is picked >6. Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > reserve/request.pl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index dffe1da4364..31990f19887 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -551,7 +551,7 @@ foreach my $biblionumber (@biblionumbers) { > > $item->{'holdallowed'} = $branchitemrule->{'holdallowed'}; > >- my $reserves_control_branch = $pickup // C4::Reserves::GetReservesControlBranch( $item, $patron_unblessed ); >+ my $reserves_control_branch = $pickup || C4::Reserves::GetReservesControlBranch( $item, $patron_unblessed ); > my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $reserves_control_branch )->{status}; > $item->{not_holdable} = $can_item_be_reserved unless ( $can_item_be_reserved eq 'OK' ); > >@@ -732,7 +732,9 @@ $template->param( biblionumbers => $biblionumbers ); > $template->param( exceeded_maxreserves => $exceeded_maxreserves ); > $template->param( exceeded_holds_per_record => $exceeded_holds_per_record ); > $template->param( subscriptionsnumber => CountSubscriptionFromBiblionumber($biblionumber)); >-$template->param( pickup => $pickup ); >+ >+# pass the userenv branch if no pickup location selected >+$template->param( pickup => $pickup || C4::Context->userenv->{branch} ); > > if ( C4::Context->preference( 'AllowHoldDateInFuture' ) ) { > $template->param( reserve_in_future => 1 ); >-- >2.31.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28118
:
119469
|
119565
|
119602
|
119603
|
119605
|
119629
|
119630
|
119673
|
119674