Attachment 119638 Details for Bug 27232 – Bug 27232: Add missing space between : and </label> in member-alt-contact-style.inc

[patch] Bug 27232: Add missing space between : and </label> in member-alt-contact-style.inc

Bug-27232-Add-missing-space-between--and-label-in-.patch (text/plain), 4.67 KB, created by Owen Leonard on 2021-04-15 15:25:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2021-04-15 15:25:47 UTC

Size: 4.67 KB

patch

obsolete

>From 15db95d589f42e9c1d54e1708fe2ee45ab9664db Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 14 Dec 2020 14:44:53 +0100
>Subject: [PATCH] Bug 27232: Add missing space between : and </label> in
> member-alt-contact-style.inc
>
>It caused the strings to appear twice in the po file
>
>Test plan:
>Apply this patch and regenerate the PO for a given language.
>Notice that the string "%s State: " only appears once in the PO file
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../prog/en/includes/member-alt-contact-style.inc      | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc
>index 2ff1a84f65..645bb99e95 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc
>@@ -56,7 +56,7 @@
>             [% ELSE %]
>                 <label for="altcontactsurname">
>             [% END %]
>-            Surname:</label>
>+            Surname: </label>
>             <input type="text" name="altcontactsurname" id="altcontactsurname" value="[% patron.altcontactsurname | html %]" />
>             [% IF ( mandatoryaltcontactsurname ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -71,7 +71,7 @@
>             [% ELSE %]
>                 <label for="altcontactfirstname">
>             [% END %]
>-            First name:</label>
>+            First name: </label>
>             <input type="text" name="altcontactfirstname" id="altcontactfirstname" value="[% patron.altcontactfirstname | html %]" />
>             [% IF ( mandatoryaltcontactfirstname ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -86,7 +86,7 @@
>             [% ELSE %]
>                 <label for="altcontactaddress1">
>             [% END %]
>-            Address:</label>
>+            Address: </label>
>             <input type="text" name="altcontactaddress1" id="altcontactaddress1" value="[% patron.altcontactaddress1 | html %]" size="40" />
>             [% IF ( mandatoryaltcontactaddress1 ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -101,7 +101,7 @@
>             [% ELSE %]
>                 <label for="altcontactaddress2">
>             [% END %]
>-            Address 2:</label>
>+            Address 2: </label>
>             <input type="text" name="altcontactaddress2" id="altcontactaddress2" value="[% patron.altcontactaddress2 | html %]" size="40" />
>             [% IF ( mandatoryaltcontactaddress2 ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -116,7 +116,7 @@
>             [% ELSE %]
>                 <label for="altcontactzipcode">
>             [% END %]
>-            ZIP/Postal code:</label>
>+            ZIP/Postal code: </label>
> <input type="text" name="altcontactzipcode" id="altcontactzipcode" value="[% patron.altcontactzipcode | html %]" size="5" />
>             [% IF ( mandatoryaltcontactzipcode ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -131,7 +131,7 @@
>             [% ELSE %]
>                 <label for="altcontactaddress3">
>             [% END %]
>-            City:</label>
>+            City: </label>
>             [% IF cities.count %]
>                 <select class="select_city" data-addressfield="altcontact" name="select_city">
>                     <option value="|||"></option>
>@@ -161,7 +161,7 @@
>             [% ELSE %]
>                 <label for="altcontactstate">
>             [% END %]
>-            State:</label>
>+            State: </label>
>             <input type="text" name="altcontactstate" id="altcontactstate" value="[% patron.altcontactstate | html %]" size="20" />
>             [% IF ( mandatoryaltcontactstate ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -176,7 +176,7 @@
>             [% ELSE %]
>                 <label for="altcontactcountry">
>             [% END %]
>-            Country:</label>
>+            Country: </label>
>             <input type="text" name="altcontactcountry" id="altcontactcountry" value="[% patron.altcontactcountry | html %]" size="20" />
>             [% IF ( mandatoryaltcontactcountry ) %]<span class="required">Required</span>[% END %]
>         </li>
>@@ -191,7 +191,7 @@
>             [% ELSE %]
>                 <label for="altcontactphone">
>             [% END %]
>-            Phone:</label>
>+            Phone: </label>
>             <input type="text" name="altcontactphone" id="altcontactphone" value="[% patron.altcontactphone | html %]" />
>             [% IF ( mandatoryaltcontactphone ) %]<span class="required">Required</span>[% END %]
>         </li>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27232: 114383 | 119638 | 119805