Bugzilla – Attachment 119643 Details for
Bug 26102
Javascript injection in intranet search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26102: Prevent XSS when To.json is used: admin/preferences.tt
Bug-26102-Prevent-XSS-when-Tojson-is-used-adminpre.patch (text/plain), 1.19 KB, created by
Owen Leonard
on 2021-04-15 15:38:46 UTC
(
hide
)
Description:
Bug 26102: Prevent XSS when To.json is used: admin/preferences.tt
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-04-15 15:38:46 UTC
Size:
1.19 KB
patch
obsolete
>From dbcbd5001ccf8840b64956873af1a06ee205a46f Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 11 Aug 2020 12:31:26 +0000 >Subject: [PATCH] Bug 26102: Prevent XSS when To.json is used: > admin/preferences.tt > >Test that preference search term highlighting works correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index b79d5d5359..8da5a7dc5c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -266,7 +266,7 @@ > }); > }); > // This is here because of its dependence on template variables, everything else should go in js/pages/preferences.js - jpw >- var to_highlight = "[% To.json( searchfield ) | $raw %]"; >+ var to_highlight = "[% To.json( searchfield ) | html %]"; > var search_jumped = [% IF ( search_jumped ) %]true[% ELSE %]false[% END %]; > </script> > [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26102
:
107579
|
108083
|
108084
|
108085
|
108086
|
108087
|
108088
|
108089
|
108090
|
119643
|
119644
|
119645
|
119646
|
119647
|
119648
|
119649
|
127669
|
127670
|
127671
|
127672
|
127673
|
127674
|
127675
|
128716
|
128717
|
128718
|
128719
|
128720
|
128721
|
128722
|
130931
|
130932
|
130933
|
130934
|
130935
|
130936
|
130999
|
131000
|
131001
|
131002
|
131003
|
131004