Attachment 119698 Details for Bug 21325 – Bug 21325: Fix t/db_dependent/Auth.t test

[patch] Bug 21325: Fix t/db_dependent/Auth.t test

Bug-21325-Fix-tdbdependentAutht-test.patch (text/plain), 1.37 KB, created by Marcel de Rooy on 2021-04-16 09:45:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2021-04-16 09:45:53 UTC

Size: 1.37 KB

patch

obsolete

>From 99c41e618976ee1521df038c9abf7bd3973ee027 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 24 Dec 2020 01:43:59 +0000
>Subject: [PATCH] Bug 21325: Fix t/db_dependent/Auth.t test
>Content-Type: text/plain; charset=utf-8
>
>This patch fixes some warnings in t/db_dependent/Auth.t.
>
>Note that it doesn't add any tests.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Auth.t | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t
>index 2c15e577ef..b221797221 100755
>--- a/t/db_dependent/Auth.t
>+++ b/t/db_dependent/Auth.t
>@@ -52,6 +52,7 @@ subtest 'checkauth() tests' => sub {
>         }
>     );
>     $cgi->mock( 'cookie', sub { return; } );
>+    $cgi->mock( 'request_method', sub { return 'POST' } );
> 
>     my $authnotrequired = 1;
>     my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
>@@ -68,6 +69,7 @@ subtest 'checkauth() tests' => sub {
>             elsif ( $param eq 'password' ) { return $db_user_pass; }
>             else { return; }
>         });
>+    $cgi->mock( 'request_method', sub { return 'POST' } );
>     ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
>     is ( $userid, undef, 'If DB user is used, it should not be logged in' );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21325: 114695 | 114696 | 119600 | 119601 | 119697 | 119698 | 119721