Bugzilla – Attachment 119739 Details for
Bug 16787
'Too many holds' message appears inappropriately and is missing data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16787: Add noReservesAllowed to club holds
Bug-16787-Add-noReservesAllowed-to-club-holds.patch (text/plain), 2.72 KB, created by
Martin Renvoize (ashimema)
on 2021-04-16 13:49:56 UTC
(
hide
)
Description:
Bug 16787: Add noReservesAllowed to club holds
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-16 13:49:56 UTC
Size:
2.72 KB
patch
obsolete
>From 2a9a78782c6aaecb2f80faf51e7529f330c8a8f4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 2 Mar 2020 16:49:16 +0000 >Subject: [PATCH] Bug 16787: Add noReservesAllowed to club holds > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > ...6787_add_noReservesAllowed_to_club_holds.perl | 16 ++++++++++++++++ > installer/data/mysql/kohastructure.sql | 2 +- > 2 files changed, 17 insertions(+), 1 deletion(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_16787_add_noReservesAllowed_to_club_holds.perl > >diff --git a/installer/data/mysql/atomicupdate/bug_16787_add_noReservesAllowed_to_club_holds.perl b/installer/data/mysql/atomicupdate/bug_16787_add_noReservesAllowed_to_club_holds.perl >new file mode 100644 >index 0000000000..7cd3fc669a >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_16787_add_noReservesAllowed_to_club_holds.perl >@@ -0,0 +1,16 @@ >+$DBversion = 'XXX'; >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do(q{ >+ ALTER TABLE club_holds_to_patron_holds >+ MODIFY COLUMN error_code >+ ENUM ( 'damaged', 'ageRestricted', 'itemAlreadyOnHold', >+ 'tooManyHoldsForThisRecord', 'tooManyReservesToday', >+ 'tooManyReserves', 'notReservable', 'cannotReserveFromOtherBranches', >+ 'libraryNotFound', 'libraryNotPickupLocation', 'cannotBeTransferred', >+ 'noReservesAllowed' >+ ) >+ }); >+ >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 16787: Add noReservesAllowed to club holds error codes)\n"; >+} >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index d391665136..f2dce203da 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1853,7 +1853,7 @@ CREATE TABLE `club_holds_to_patron_holds` ( > `club_hold_id` int(11) NOT NULL, > `patron_id` int(11) NOT NULL, > `hold_id` int(11) DEFAULT NULL, >- `error_code` enum('damaged','ageRestricted','itemAlreadyOnHold','tooManyHoldsForThisRecord','tooManyReservesToday','tooManyReserves','notReservable','cannotReserveFromOtherBranches','libraryNotFound','libraryNotPickupLocation','cannotBeTransferred') COLLATE utf8mb4_unicode_ci DEFAULT NULL, >+ `error_code` enum('damaged','ageRestricted','itemAlreadyOnHold','tooManyHoldsForThisRecord','tooManyReservesToday','tooManyReserves','notReservable','cannotReserveFromOtherBranches','libraryNotFound','libraryNotPickupLocation','cannotBeTransferred','noReservesAllowed') COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `error_message` varchar(100) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > PRIMARY KEY (`id`), > KEY `clubs_holds_paton_holds_ibfk_1` (`club_hold_id`), >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16787
:
52652
|
68894
|
68895
|
72827
|
72828
|
72889
|
91146
|
91147
|
91148
|
91149
|
96152
|
97403
|
99949
|
99950
|
100951
|
101473
|
101474
|
101475
|
101895
|
107793
|
107794
|
107795
|
114675
|
114676
|
114677
|
119279
|
119280
|
119281
|
119335
|
119336
|
119337
|
119616
|
119617
|
119619
|
119620
|
119621
|
119622
|
119623
|
119738
| 119739 |
119740
|
119741
|
119942
|
120009