Bugzilla – Attachment 119744 Details for
Bug 27656
misc/cronjobs/longoverdue.pl better error message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27656: misc/cronjobs/longoverdue.pl better error message
Bug-27656-misccronjobslongoverduepl-better-error-m.patch (text/plain), 1.67 KB, created by
Martin Renvoize (ashimema)
on 2021-04-16 14:04:05 UTC
(
hide
)
Description:
Bug 27656: misc/cronjobs/longoverdue.pl better error message
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2021-04-16 14:04:05 UTC
Size:
1.67 KB
patch
obsolete
>From 729b93247a4b3b33a37cbf6160b7c04476211750 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Mon, 8 Feb 2021 15:28:35 +0100 >Subject: [PATCH] Bug 27656: misc/cronjobs/longoverdue.pl better error message > >There are two ways of configuring misc/cronjobs/longoverdue.pl : >use --lost arg or system preferencies DefaultLongOverdueLostValue and DefaultLongOverdueDays. > >Actually if you don't use any of it, you get a message : > "ERROR: No --lost (-l) option defined" >Should also say something about preferencies : > "ERROR: No --lost (-l) option no system preferences DefaultLongOverdueLostValue/DefaultLongOverdueDays defined" > >Test plan: >1) Set empty preferences DefaultLongOverdueLostValue and DefaultLongOverdueDays >2) Run : misc/cronjobs/longoverdue.pl --maxdays 365 >3) You see error message >4) Set DefaultLongOverdueLostValue = 1 and DefaultLongOverdueDays = 90 >5) Run : misc/cronjobs/longoverdue.pl --maxdays 365 >6) You don't see error message > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > misc/cronjobs/longoverdue.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl >index 1f4a380bab..c12a95d6f2 100755 >--- a/misc/cronjobs/longoverdue.pl >+++ b/misc/cronjobs/longoverdue.pl >@@ -270,7 +270,7 @@ if ( ! defined($lost) ) { > else { > pod2usage( { > -exitval => 1, >- -msg => q|ERROR: No --lost (-l) option defined|, >+ -msg => q|ERROR: No --lost (-l) option or system preferences DefaultLongOverdueLostValue/DefaultLongOverdueDays defined|, > } ); > } > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27656
:
116510
|
119093
|
119707
| 119744