Attachment 119745 Details for Bug 27836 – Bug 27836: Document that CirControl changes which calendar is being used

[patch] Bug 27836: Document that CirControl changes which calendar is being used

Bug-27836-Document-that-CirControl-changes-which-c.patch (text/plain), 1.61 KB, created by Martin Renvoize (ashimema) on 2021-04-16 14:05:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2021-04-16 14:05:24 UTC

Size: 1.61 KB

patch

obsolete

>From 11ff8030efc0e26f70690494362eb412497a6c26 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Tue, 2 Mar 2021 17:06:09 +0200
>Subject: [PATCH] Bug 27836: Document that CirControl changes which calendar is
> being used
>
>You can verify that which branch's Koha calendar is being used to
>calculate fines by reading for example the code in
>C4::Circulation::_CalculateAndUpdateFine() There you can see that
>$control_branchcode variable is being passed to
>C4::Overdues::CalcFine() and if you trace that you will see in the end
>it decides which branch's calendar to use for calculating chargeable
>overdue fine days.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/admin/preferences/circulation.pref          | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 2ccb4e4b10..0bf3b7c518 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -262,7 +262,7 @@ Circulation:
>                   0: "Don't use"
>             - the transport cost matrix for calculating optimal holds filling between libraries.
>         -
>-            - Use the checkout and fines rules of
>+            - Use the calendar and circulation rules of
>             - pref: CircControl
>               type: choice
>               choices:
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27836: 117528 | 119334 | 119745